enhance: force using StringComparison.Ordinal

This commit is contained in:
leo 2024-03-14 11:09:05 +08:00
parent cd2ecb109a
commit f6eb1281b5
12 changed files with 23 additions and 19 deletions

View file

@ -1,4 +1,6 @@
namespace SourceGit.Models {
using System;
namespace SourceGit.Models {
public enum ChangeViewMode {
List,
Grid,
@ -36,12 +38,12 @@
WorkTree = workTree;
if (index == ChangeState.Renamed || workTree == ChangeState.Renamed) {
var idx = Path.IndexOf('\t');
var idx = Path.IndexOf('\t', StringComparison.Ordinal);
if (idx >= 0) {
OriginalPath = Path.Substring(0, idx);
Path = Path.Substring(idx + 1);
} else {
idx = Path.IndexOf(" -> ");
idx = Path.IndexOf(" -> ", StringComparison.Ordinal);
if (idx > 0) {
OriginalPath = Path.Substring(0, idx);
Path = Path.Substring(idx + 4);

View file

@ -31,7 +31,7 @@ namespace SourceGit.Models {
}
public static void ParseUserAndTime(string data, ref User user, ref ulong time) {
var userEndIdx = data.IndexOf('>');
var userEndIdx = data.IndexOf('>', StringComparison.Ordinal);
if (userEndIdx < 0) return;
var timeEndIdx = data.IndexOf(' ', userEndIdx + 2);

View file

@ -23,7 +23,7 @@ namespace SourceGit.Models {
if (Caches.ContainsKey(data)) {
return Caches[data];
} else {
var nameEndIdx = data.IndexOf('<');
var nameEndIdx = data.IndexOf('<', System.StringComparison.Ordinal);
var name = nameEndIdx >= 2 ? data.Substring(0, nameEndIdx - 1) : string.Empty;
var email = data.Substring(nameEndIdx + 1);

View file

@ -142,7 +142,7 @@ namespace SourceGit.Models {
} else if (name.Equals("HEAD", StringComparison.Ordinal) ||
name.StartsWith("refs/heads/", StringComparison.Ordinal) ||
name.StartsWith("refs/remotes/", StringComparison.Ordinal) ||
name.StartsWith("worktrees/")) {
name.StartsWith("worktrees/", StringComparison.Ordinal)) {
_updateBranch = DateTime.Now.AddSeconds(.5).ToFileTime();
} else if (name.StartsWith("objects/", StringComparison.Ordinal) || name.Equals("index", StringComparison.Ordinal)) {
_updateWC = DateTime.Now.AddSeconds(1).ToFileTime();