dearwolf/sourcegit
1
0
Fork 0
mirror of https://github.com/sourcegit-scm/sourcegit synced 2025-05-23 13:14:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

enhance: force using StringComparison.Ordinal

Browse source
This commit is contained in:
leo 2024-03-14 11:09:05 +08:00
parent cd2ecb109a
commit f6eb1281b5
12 changed files with 23 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/Commands/Blame.cs
View file

@ -38,7 +38,7 @@ namespace SourceGit.Commands {
if (_result.IsBinary) return;
if (string.IsNullOrEmpty(line)) return;
if (line.IndexOf('\0') >= 0) {
if (line.IndexOf('\0', StringComparison.Ordinal) >= 0) {
_result.IsBinary = true;
_result.LineInfos.Clear();
return;

2
src/Commands/Config.cs
View file

@ -17,7 +17,7 @@ namespace SourceGit.Commands {
if (output.IsSuccess) {
var lines = output.StdOut.Split(new char[] { '\r', '\n' }, StringSplitOptions.RemoveEmptyEntries);
foreach (var line in lines) {
var idx = line.IndexOf('=');
var idx = line.IndexOf('=', StringComparison.Ordinal);
if (idx != -1) {
var key = line.Substring(0, idx).Trim();
var val = line.Substring(idx+1).Trim();

4
src/Commands/QueryBranches.cs
View file

@ -36,14 +36,14 @@ namespace SourceGit.Commands {
var branch = new Models.Branch();
var refName = parts[0];
if (refName.EndsWith("/HEAD")) return;
if (refName.EndsWith("/HEAD", StringComparison.Ordinal)) return;
if (refName.StartsWith(PREFIX_LOCAL, StringComparison.Ordinal)) {
branch.Name = refName.Substring(PREFIX_LOCAL.Length);
branch.IsLocal = true;
} else if (refName.StartsWith(PREFIX_REMOTE, StringComparison.Ordinal)) {
var name = refName.Substring(PREFIX_REMOTE.Length);
var shortNameIdx = name.IndexOf('/');
var shortNameIdx = name.IndexOf('/', StringComparison.Ordinal);
if (shortNameIdx < 0) return;
branch.Remote = name.Substring(0, shortNameIdx);

2
src/Commands/QueryCommits.cs
View file

@ -51,7 +51,7 @@ namespace SourceGit.Commands {
current = new Models.Commit();
line = line.Substring(7);
var decoratorStart = line.IndexOf('(');
var decoratorStart = line.IndexOf('(', StringComparison.Ordinal);
if (decoratorStart < 0) {
current.SHA = line.Trim();
} else {