code_style: whitespace cleanup

This commit is contained in:
Nathan Baulch 2025-06-12 09:19:34 +10:00
parent dde08c507a
commit f4572c640b
44 changed files with 65 additions and 88 deletions

View file

@ -100,7 +100,7 @@ dotnet_naming_symbols.private_internal_fields.applicable_kinds = field
dotnet_naming_symbols.private_internal_fields.applicable_accessibilities = private, internal
dotnet_naming_style.camel_case_underscore_style.required_prefix = _
dotnet_naming_style.camel_case_underscore_style.capitalization = camel_case
dotnet_naming_style.camel_case_underscore_style.capitalization = camel_case
# use accessibility modifiers
dotnet_style_require_accessibility_modifiers = for_non_interface_members:suggestion

View file

@ -204,7 +204,6 @@ namespace SourceGit.Models
for (int i = 0; i <= half; i++)
{
for (int j = -i; j <= i; j += 2)
{
var idx = j + half;

View file

@ -16,7 +16,7 @@
<Style.Resources>
<x:Double x:Key="ScrollBarSize">12</x:Double>
</Style.Resources>
<Setter Property="ShowDelay" Value="0:0:0.1"/>
<Setter Property="HideDelay" Value="0:0:0.2"/>
</Style>
@ -38,7 +38,7 @@
<Setter Property="BorderThickness" Value="0"/>
<Setter Property="Padding" Value="0"/>
</Style>
<Style Selector="Window[WindowState=Maximized].fix_maximized_padding">
<Setter Property="Padding" Value="8,6,8,8"/>
</Style>
@ -206,7 +206,7 @@
<DropShadowEffect OffsetX="0" OffsetY="0" BlurRadius="4" Color="Black" Opacity=".6"/>
</Border.Effect>
</Border>
<Border Name="LayoutRoot"
Margin="4"
Padding="12"
@ -318,7 +318,7 @@
<Setter Property="Foreground" Value="DarkOrange"/>
<Setter Property="TextDecorations" Value="Underline"/>
</Style>
<Style Selector="SelectableTextBlock">
<Setter Property="HorizontalAlignment" Value="Left"/>
<Setter Property="VerticalAlignment" Value="Center"/>
@ -336,7 +336,7 @@
<Path Width="11" Height="11" Data="{StaticResource Icons.Copy}" VerticalAlignment="Center"/>
</MenuItem.Icon>
</MenuItem>
<MenuItem Header="{DynamicResource Text.CopyAllText}"
Command="{x:Static s:App.CopyTextBlockCommand}"
CommandParameter="{Binding $parent[SelectableTextBlock]}">
@ -524,7 +524,7 @@
<Style Selector="Button.flat.primary ToolTip TextBlock">
<Setter Property="Foreground" Value="{DynamicResource Brush.FG1}"/>
</Style>
<Style Selector="SplitButton">
<Setter Property="MinHeight" Value="24"/>
<Setter Property="Template">
@ -569,17 +569,17 @@
</Grid>
</ControlTemplate>
</Setter>
<Style Selector="^:disabled /template/ Button">
<Setter Property="BorderThickness" Value="1"/>
<Setter Property="BorderBrush" Value="{DynamicResource Brush.Border2}"/>
<Setter Property="Background" Value="Transparent"/>
</Style>
<Style Selector="^:disabled TextBlock">
<Setter Property="Foreground" Value="{DynamicResource Brush.FG2}"/>
</Style>
<Style Selector="^:disabled Path">
<Setter Property="Fill" Value="{DynamicResource Brush.FG2}"/>
</Style>
@ -737,7 +737,7 @@
<Setter Property="Background" Value="{DynamicResource Brush.Accent}" />
<Setter Property="Opacity" Value=".8"/>
</Style>
</Style>
</Style>
<Style Selector="ContextMenu">
<Setter Property="HorizontalOffset" Value="-4"/>
@ -849,7 +849,7 @@
</DataTemplate>
</ContentPresenter.DataTemplates>
</ContentPresenter>
<TextBlock x:Name="PART_InputGestureText"
Grid.Column="2"
Classes="CaptionTextBlockStyle"
@ -871,7 +871,7 @@
Foreground="{DynamicResource MenuFlyoutItemKeyboardAcceleratorTextForeground}"
FontSize="11"
IsVisible="{TemplateBinding (v:MenuItemExtension.Command), Converter={x:Static StringConverters.IsNotNullOrEmpty}}"/>
<Path Name="PART_ChevronPath"
Width="6"
Data="M573 512 215 881c-20 20-20 51 0 61l61 61c20 20 51 20 61 0l461-461c10-10 10-20 10-31s0-20-10-31L338 20C317 0 287 0 276 20L215 82c-20 20-20 51 0 61L573 512z"
@ -914,7 +914,7 @@
</Panel>
</ControlTemplate>
</Setter>
<Style Selector="^:icon /template/ ContentControl#PART_IconPresenter">
<Setter Property="IsVisible" Value="True" />
</Style>
@ -956,7 +956,7 @@
<Style Selector="MenuItem.filter_mode_switcher">
<Setter Property="Height" Value="48"/>
<Setter Property="StaysOpenOnClick" Value="True"/>
<Style Selector="^:selected">
<Style Selector="^ /template/ Border#PART_LayoutRoot">
<Setter Property="Background" Value="Transparent" />
@ -1179,7 +1179,7 @@
<Setter Property="Data" Value="M 0 4 L 8 4 L 4 8 Z" />
</Style>
</Style>
<Style Selector="ToggleButton.folder">
<Setter Property="Margin" Value="0" />
<Setter Property="Background" Value="Transparent"/>
@ -1252,7 +1252,7 @@
<Style Selector="ToggleButton.toggle_untracked:pointerover /template/ Path#PART_IndicatorIcon">
<Setter Property="Opacity" Value="1"/>
</Style>
<Style Selector="ToggleButton.show_as_tree">
<Setter Property="Margin" Value="0" />
<Setter Property="Background" Value="Transparent"/>
@ -1284,7 +1284,7 @@
<Setter Property="Opacity" Value="1"/>
</Style>
</Style>
<Style Selector="Slider">
<Style.Resources>
<Thickness x:Key="SliderTopHeaderMargin">0,0,0,4</Thickness>

View file

@ -55,7 +55,7 @@
<Color x:Key="Color.InlineCode">#FF383838</Color>
</ResourceDictionary>
</ResourceDictionary.ThemeDictionaries>
<SolidColorBrush x:Key="Brush.Window" Color="{DynamicResource Color.Window}"/>
<SolidColorBrush x:Key="Brush.WindowBorder" Color="{DynamicResource Color.WindowBorder}"/>
<SolidColorBrush x:Key="Brush.TitleBar" Color="{DynamicResource Color.TitleBar}"/>

View file

@ -115,7 +115,7 @@ namespace SourceGit.ViewModels
break;
}
}
}
}
}
private void SetBlameData(string commitSHA)
@ -145,7 +145,7 @@ namespace SourceGit.ViewModels
}
});
}, token);
}
}
Task.Run(() =>
{

View file

@ -244,7 +244,7 @@ namespace SourceGit.ViewModels
return;
}
}
if (firstRemoteBranch == null)
firstRemoteBranch = remoteBranch;
}

View file

@ -1339,7 +1339,7 @@ namespace SourceGit.ViewModels
{
foreach (var b in _branches)
{
if (b.IsLocal &&
if (b.IsLocal &&
b.Upstream.Equals(branch.FullName, StringComparison.Ordinal) &&
b.TrackStatus.Ahead.Count == 0)
{

View file

@ -62,7 +62,6 @@
</Button>
</StackPanel>
<TextBlock x:Name="TxtCopyright" Margin="0,40,0,0" Foreground="{DynamicResource Brush.FG2}"/>
</StackPanel>
</Grid>

View file

@ -10,4 +10,3 @@ namespace SourceGit.Views
}
}
}

View file

@ -48,7 +48,7 @@
<Path Grid.Column="0"
Width="14" Height="14"
Data="{StaticResource Icons.File}"/>
<TextBlock Grid.Column="1"
Margin="4,0,0,0"
VerticalAlignment="Center"
@ -61,7 +61,7 @@
Command="{Binding Back}">
<Path Width="12" Height="12" Data="{StaticResource Icons.TriangleLeft}"/>
</Button>
<Button Grid.Column="3"
Classes="icon_button"
IsEnabled="{Binding CanForward}"
@ -80,7 +80,7 @@
<TextBlock Grid.Column="1"
Text="{Binding Revision.Subject}"
TextTrimming="CharacterEllipsis"/>
</Grid>
</Grid>
</Border>
</Grid>
</Border>

View file

@ -96,4 +96,3 @@
</ListBox.ItemTemplate>
</ListBox>
</UserControl>

View file

@ -479,12 +479,12 @@ namespace SourceGit.Views
if (branches.Find(x => x.IsCurrent) != null)
return;
if (branches.Count == 1)
repo.DeleteBranch(branches[0]);
else
repo.DeleteMultipleBranches(branches, branches[0].IsLocal);
e.Handled = true;
}
@ -537,4 +537,3 @@ namespace SourceGit.Views
private bool _disableSelectionChangingEvent = false;
}
}

View file

@ -120,7 +120,7 @@
<Binding Path="$self.(ToolTip.Tip)" Converter="{x:Static ObjectConverters.IsNotNull}"/>
</MultiBinding>
</ToolTip.IsOpen>
<TextBlock.DataTemplates>
<DataTemplate DataType="m:Commit">
<StackPanel MinWidth="400" Orientation="Vertical">
@ -165,7 +165,7 @@
<Binding Path="$self.(ToolTip.Tip)" Converter="{x:Static ObjectConverters.IsNotNull}"/>
</MultiBinding>
</ToolTip.IsOpen>
<TextBlock.DataTemplates>
<DataTemplate DataType="m:Commit">
<StackPanel MinWidth="400" Orientation="Vertical">
@ -209,7 +209,7 @@
<Binding Path="$self.(ToolTip.Tip)" Converter="{x:Static ObjectConverters.IsNotNull}"/>
</MultiBinding>
</ToolTip.IsOpen>
<v:CommitMessagePresenter.DataTemplates>
<DataTemplate DataType="m:Commit">
<StackPanel MinWidth="400" Orientation="Vertical">

View file

@ -67,7 +67,7 @@
<Grid ColumnDefinitions="Auto,Auto,Auto,Auto,*" Margin="0,4">
<Button Grid.Column="0"
Classes="icon_button"
Width="24"
Width="24"
Margin="0,0,4,0" Padding="0"
Click="OnOpenCommitMessagePicker"
IsVisible="{Binding #ThisControl.ShowAdvancedOptions}"
@ -120,4 +120,3 @@
</Grid>
</Border>
</UserControl>

View file

@ -121,7 +121,7 @@
<Grid RowDefinitions="30,32,30,32,30,Auto,32">
<TextBlock Grid.Row="0" Margin="0,0,0,4" Text="{DynamicResource Text.ConfigureWorkspace.Name}" VerticalAlignment="Bottom"/>
<TextBox Grid.Row="1" CornerRadius="3" Height="28" Text="{Binding Name, Mode=TwoWay}"/>
<TextBlock Grid.Row="2" Margin="0,0,0,4" Text="{DynamicResource Text.Preferences.Git.DefaultCloneDir}" VerticalAlignment="Bottom"/>
<TextBox Grid.Row="3" CornerRadius="3" Height="28" Text="{Binding DefaultCloneDir, Mode=TwoWay}">
<TextBox.InnerRightContent>
@ -130,10 +130,10 @@
</Button>
</TextBox.InnerRightContent>
</TextBox>
<TextBlock Grid.Row="4" Margin="0,0,0,4" Text="{DynamicResource Text.ConfigureWorkspace.Color}" VerticalAlignment="Bottom"/>
<v:ColorPicker Grid.Row="5" HorizontalAlignment="Left" Value="{Binding Color, Mode=TwoWay}"/>
<CheckBox Grid.Row="6"
Content="{DynamicResource Text.ConfigureWorkspace.Restore}"
IsChecked="{Binding RestoreOnStartup, Mode=TwoWay}"/>

View file

@ -14,15 +14,15 @@
<StackPanel Orientation="Vertical" IsVisible="{Binding !IsResolved}">
<Path Width="64" Height="64" Data="{StaticResource Icons.Conflict}" Fill="{DynamicResource Brush.FG2}" HorizontalAlignment="Center"/>
<TextBlock Margin="0,16" FontSize="20" FontWeight="Bold" Text="{DynamicResource Text.WorkingCopy.Conflicts}" Foreground="{DynamicResource Brush.FG2}" HorizontalAlignment="Center"/>
<StackPanel Orientation="Horizontal" HorizontalAlignment="Center" Margin="0,0,0,8">
<Border Height="16" VerticalAlignment="Center" Background="Red" CornerRadius="8">
<TextBlock Classes="primary" Text="{Binding Marker}" Foreground="White" FontWeight="Bold" Margin="8,0" FontSize="10"/>
</Border>
<TextBlock Margin="8,0,0,0" VerticalAlignment="Center" Text="{Binding Description}"/>
</StackPanel>
<Border Margin="16,0" Padding="8" CornerRadius="4" BorderThickness="1" BorderBrush="{DynamicResource Brush.Border2}">
<Border.DataTemplates>
<DataTemplate DataType="vm:ConflictSourceBranch">
@ -96,7 +96,7 @@
</StackPanel>
</DataTemplate>
</Border.DataTemplates>
<Border.IsVisible>
<MultiBinding Converter="{x:Static BoolConverters.And}">
<Binding Path="Theirs" Converter="{x:Static ObjectConverters.IsNotNull}"/>

View file

@ -56,11 +56,11 @@
<TextBlock Text="{Binding Name}" Margin="0,0,8,0"/>
<Border Height="16" CornerRadius="8" Padding="8,0" VerticalAlignment="Center" Background="Green">
<TextBlock Text="{Binding Type}" VerticalAlignment="Center" FontSize="11" Foreground="White"/>
</Border>
</Border>
</StackPanel>
</DataTemplate>
</ComboBox.SelectionBoxItemTemplate>
<ComboBox.ItemTemplate>
<DataTemplate DataType="m:ConventionalCommitType">
<Grid Height="22">

View file

@ -10,4 +10,3 @@ namespace SourceGit.Views
}
}
}

View file

@ -163,5 +163,3 @@ namespace SourceGit.Views
}
}
}

View file

@ -133,7 +133,7 @@
AheadBrush="{DynamicResource Brush.Accent}"
BehindBrush="{DynamicResource Brush.FG1}"
VerticalAlignment="Center"/>
<v:BisectStateIndicator Grid.Column="1"
Background="{DynamicResource Brush.Contents}"
Foreground="{DynamicResource Brush.FG1}"

View file

@ -69,10 +69,10 @@
<TextBlock Grid.Row="7" Grid.Column="0" Classes="primary bold" Text="{OnPlatform Ctrl+Q, macOS=⌘+Q}"/>
<TextBlock Grid.Row="7" Grid.Column="1" Margin="16,0,0,0" Text="{DynamicResource Text.Quit}" />
<TextBlock Grid.Row="8" Grid.Column="0" Classes="primary bold" Text="{OnPlatform Ctrl+Shift+P, macOS=⌘+⇧+P}"/>
<TextBlock Grid.Row="8" Grid.Column="1" Margin="16,0,0,0" Text="{DynamicResource Text.Hotkeys.Global.SwitchWorkspace}" />
<TextBlock Grid.Row="9" Grid.Column="0" Classes="primary bold" Text="{OnPlatform Ctrl+P, macOS=⌘+P}"/>
<TextBlock Grid.Row="9" Grid.Column="1" Margin="16,0,0,0" Text="{DynamicResource Text.Hotkeys.Global.SwitchTab}" />
</Grid>

View file

@ -102,7 +102,7 @@
</DataTemplate>
</ContentControl.DataTemplates>
</ContentControl>
<!-- Workspace/Pages Switcher -->
<Border Grid.Row="0" Grid.RowSpan="2"
Background="Transparent"
@ -115,7 +115,7 @@
<DataTemplate DataType="vm:WorkspaceSwitcher">
<v:WorkspaceSwitcher/>
</DataTemplate>
<DataTemplate DataType="vm:LauncherPageSwitcher">
<v:LauncherPageSwitcher/>
</DataTemplate>

View file

@ -13,7 +13,7 @@
Text="{DynamicResource Text.Launcher.Pages}"
FontWeight="Bold"
HorizontalAlignment="Center"/>
<TextBox Grid.Row="1"
Height="24"
Margin="4,8,4,0"

View file

@ -46,4 +46,3 @@ namespace SourceGit.Views
}
}
}

View file

@ -80,7 +80,7 @@
VerticalAlignment="Center"
IsVisible="{Binding DirtyBrush, Converter={x:Static ObjectConverters.IsNotNull}}"
Fill="{Binding DirtyBrush}"/>
<TextBlock Grid.Column="1"
Classes="primary"
VerticalAlignment="Center"
@ -89,7 +89,7 @@
Text="{Binding Node.Name}"
IsHitTestVisible="False"/>
</Grid>
<TextBlock Grid.Column="1"
Classes="primary"
HorizontalAlignment="Stretch" VerticalAlignment="Center"
@ -98,7 +98,7 @@
Text="{DynamicResource Text.PageTabBar.Welcome.Title}"
IsVisible="{Binding !Node.IsRepository}"
IsHitTestVisible="False"/>
<Button Grid.Column="2"
Classes="icon_button"
Width="16" Height="16" Margin="12,0"

View file

@ -10,5 +10,3 @@ namespace SourceGit.Views
}
}
}

View file

@ -96,7 +96,7 @@ namespace SourceGit.Views
FontSize,
Foreground);
context.DrawText(formatted, new Point(offsetX, 0));
if (isName)
{
var lineY = formatted.Baseline + 2;

View file

@ -769,7 +769,7 @@
Click="OnBisectCommand"
Tag="reset"/>
</Grid>
<Border Grid.Row="2" Background="{DynamicResource Brush.ToolBar}" BorderThickness="0,0,0,1" BorderBrush="{DynamicResource Brush.Border0}">
<Border.IsVisible>
<MultiBinding Converter="{x:Static BoolConverters.And}">

View file

@ -102,7 +102,7 @@
<Button Classes="icon_button" Width="32" Margin="8,0,0,0" Command="{Binding Cleanup}" ToolTip.Tip="{DynamicResource Text.Repository.Clean}">
<Path Width="14" Height="14" Margin="0,1,0,0" Data="{StaticResource Icons.Clean}"/>
</Button>
</Button>
</StackPanel>
<StackPanel Grid.Column="2" Orientation="Horizontal" HorizontalAlignment="Right" Margin="0,0,4,0">
@ -132,4 +132,3 @@
</StackPanel>
</Grid>
</UserControl>

View file

@ -152,4 +152,3 @@ namespace SourceGit.Views
}
}
}

View file

@ -97,4 +97,3 @@
</DataTemplate>
</UserControl.DataTemplates>
</UserControl>

View file

@ -163,4 +163,3 @@ namespace SourceGit.Views
}
}
}

View file

@ -144,7 +144,7 @@
</ToggleButton>
</Grid>
</Border>
<v:RevisionFileContentViewer Grid.Row="1" Content="{Binding ViewRevisionFileContent}"/>
</Grid>
</Border>

View file

@ -25,7 +25,6 @@ namespace SourceGit.Views
TextArea.TextView.Margin = new Thickness(4, 0);
TextArea.TextView.Options.EnableHyperlinks = false;
TextArea.TextView.Options.EnableEmailHyperlinks = false;
}
protected override void OnLoaded(RoutedEventArgs e)

View file

@ -203,7 +203,7 @@
</Grid>
</StackPanel>
</ToolTip.Tip>
<Grid ColumnDefinitions="16,*,Auto" Margin="8,0,0,0" VerticalAlignment="Center">
<Path Grid.Column="0" Width="10" Height="10" Margin="8,0" Data="{StaticResource Icons.Submodule}"/>
<TextBlock Grid.Column="1" Text="{Binding Path}" ClipToBounds="True" Classes="primary" TextTrimming="CharacterEllipsis"/>

View file

@ -41,7 +41,7 @@
</StackPanel>
</DataTemplate>
</ListBox.DataTemplates>
<ListBox.ItemTemplate>
<DataTemplate DataType="vm:TagTreeNode">
<Border Height="24"
@ -50,7 +50,7 @@
DoubleTapped="OnItemDoubleTapped"
ContextRequested="OnItemContextRequested"
ToolTip.Tip="{Binding ToolTip}"
ToolTip.Placement="Right">
ToolTip.Placement="Right">
<Grid ColumnDefinitions="16,Auto,*,Auto"
Margin="{Binding Depth, Converter={x:Static c:IntConverters.ToTreeMargin}}"
VerticalAlignment="Center">
@ -111,7 +111,7 @@
<TextBlock Text="{Binding Message}" IsVisible="{Binding Message, Converter={x:Static StringConverters.IsNotNullOrEmpty}}"/>
</StackPanel>
</ToolTip.Tip>
<Grid ColumnDefinitions="Auto,*,Auto" VerticalAlignment="Center">
<Path Grid.Column="0"
Margin="8,0,0,0"
@ -133,4 +133,3 @@
</DataTemplate>
</UserControl.DataTemplates>
</UserControl>

View file

@ -230,4 +230,3 @@ namespace SourceGit.Views
}
}
}

View file

@ -44,7 +44,7 @@
<ColumnDefinition Width="4"/>
<ColumnDefinition Width="*"/>
</Grid.ColumnDefinitions>
<ListBox Grid.Column="0"
Padding="4"
Background="{DynamicResource Brush.Contents}"
@ -84,14 +84,14 @@
Width="14" Height="14"
Margin="4,0,4,0"
IsVisible="{Binding !IsComplete}"/>
<TextBlock Grid.Column="1"
Classes="primary"
Margin="4,0,0,0"
Text="{Binding Name}"
VerticalAlignment="Center"
TextTrimming="CharacterEllipsis"/>
<v:CommandLogTime Grid.Column="2"
Classes="primary"
Margin="4,0"

View file

@ -14,7 +14,7 @@
<ColumnDefinition Width="2*" MinWidth="600"/>
<ColumnDefinition Width="1*"/>
</Grid.ColumnDefinitions>
<!-- Managed Repositories -->
<Grid Grid.Row="0" Grid.Column="1" Margin="8" RowDefinitions="Auto,*">
<!-- Search Box -->

View file

@ -32,4 +32,3 @@
</StackPanel>
</Grid>
</UserControl>

View file

@ -50,4 +50,3 @@ namespace SourceGit.Views
}
}
}

View file

@ -168,7 +168,7 @@
ViewMode="{Binding Source={x:Static vm:Preferences.Instance}, Path=StagedChangeViewMode, Mode=TwoWay}"/>
</Grid>
</Border>
<!-- Staged Changes -->
<v:ChangeCollectionView Grid.Row="1"
x:Name="StagedChangesView"
@ -357,7 +357,7 @@
<Binding Path="CommitMessage" Converter="{x:Static c:StringConverters.IsNotNullOrWhitespace}"/>
</MultiBinding>
</Button.IsEnabled>
<Button.IsVisible>
<MultiBinding Converter="{x:Static BoolConverters.And}">
<Binding Path="HasRemotes"/>

View file

@ -12,7 +12,7 @@
Text="{DynamicResource Text.Launcher.Workspaces}"
FontWeight="Bold"
HorizontalAlignment="Center"/>
<TextBox Grid.Row="1"
Height="24"
Margin="4,8,4,0"
@ -108,4 +108,3 @@
</ListBox>
</Grid>
</UserControl>

View file

@ -46,4 +46,3 @@ namespace SourceGit.Views
}
}
}