dearwolf/sourcegit
1
0
Fork 0
mirror of https://github.com/sourcegit-scm/sourcegit synced 2025-05-22 04:34:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

code_review: PR #480

Browse source 
* remove `string.IsNullOrEmpty(OS.ShellOrTerminal)` checking from detail backend since it has been checked by `Native.OS.OpenTerminal`
* remove `ViewModels.Preference.IsTerminalConfigured` because it is only used by itself (Unlike `IsGitConfigured`).
* add `Native.OS.TestShellOrTerminal` and use it instead of setting `Preference.ShellOrTerminal` directly, because we have binded a callback that will save preference into file when its property changed. It may cause lag in some enviroments if we saving preference into file too frequently (see PR #436).
* run `dotnet format`
This commit is contained in:
leo 2024-09-17 22:09:51 +08:00
parent 65c2087f6b
commit bc633e4085
No known key found for this signature in database
5 changed files with 44 additions and 61 deletions
Download patch file Download diff file Expand all files Collapse all files

11
src/Native/OS.cs
View file

@ -74,12 +74,17 @@ namespace SourceGit.Native
return _backend.FindGitExecutable();
}
public static void SetShellOrTerminal(Models.ShellOrTerminal shellOrTerminal)
public static bool TestShellOrTerminal(Models.ShellOrTerminal shell)
{
if (shellOrTerminal == null)
return !string.IsNullOrEmpty(_backend.FindTerminal(shell));
}
public static void SetShellOrTerminal(Models.ShellOrTerminal shell)
{
if (shell == null)
ShellOrTerminal = string.Empty;
else
ShellOrTerminal = _backend.FindTerminal(shellOrTerminal);
ShellOrTerminal = _backend.FindTerminal(shell);
}
public static void OpenInFileManager(string path, bool select = false)