dearwolf/sourcegit
1
0
Fork 0
mirror of https://github.com/sourcegit-scm/sourcegit synced 2025-06-16 07:55:00 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

code_review: PR #1402

Browse source 
- it's unnecessary to implement `IEnumerable` interface
- we should check `IsIntersecting` before creating `InlineElement` to avoid unnecessary works suck as running `git cat-file -t <hash>`
- sort whold list after all elements have been added to avoid unnecessary memmove in `Insert`

Signed-off-by: leo <longshuang@msn.cn>
This commit is contained in:
leo 2025-06-08 11:09:20 +08:00
parent fe54d30b70
commit 84fb39f97a
No known key found for this signature in database
7 changed files with 52 additions and 88 deletions
Download patch file Download diff file Expand all files Collapse all files

9
src/Views/CommitSubjectPresenter.cs
View file

@ -167,6 +167,9 @@ namespace SourceGit.Views
var start = match.Index;
var len = match.Length;
if (_elements.Intersect(start, len) != null)
continue;
_elements.Add(new Models.InlineElement(Models.InlineElementType.Code, start, len, string.Empty));
}
@ -174,6 +177,7 @@ namespace SourceGit.Views
foreach (var rule in rules)
rule.Matches(_elements, subject);
_elements.Sort();
_needRebuildInlines = true;
InvalidateVisual();
}
@ -247,8 +251,9 @@ namespace SourceGit.Views
var codeTypeface = new Typeface(codeFontFamily, FontStyle.Normal, FontWeight);
var pos = 0;
var x = 0.0;
foreach (var elem in _elements)
for (var i = 0; i < _elements.Count; i++)
{
var elem = _elements[i];
if (elem.Start > pos)
{
var normal = new FormattedText(
@ -350,7 +355,7 @@ namespace SourceGit.Views
}
}
private Models.InlineElementCollector _elements = [];
private Models.InlineElementCollector _elements = new();
private List<Inline> _inlines = [];
private Models.InlineElement _lastHover = null;
private bool _needRebuildInlines = false;