dearwolf/sourcegit
1
0
Fork 0
mirror of https://github.com/sourcegit-scm/sourcegit synced 2025-05-22 12:45:00 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

code_review: code review for PR #33

Browse source 
* use PNG instead of SVG for external tool icons and remove dependency `Avalonia.SVG`
* remove unused property `IsVSCodeFound` and `IsFleetFound`
* find VS from registry first
* remove compile warning CA1416
* remove unused enum `OS.Platforms`
This commit is contained in:
leo 2024-03-28 17:42:13 +08:00
parent 370b9bd31e
commit 4659fbd901
10 changed files with 85 additions and 162 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/SourceGit/ViewModels/Repository.cs
View file

@ -49,18 +49,6 @@ namespace SourceGit.ViewModels
set;
} = new AvaloniaList<string>();
[JsonIgnore]
public bool IsVSCodeFound
{
get => !string.IsNullOrEmpty(Native.OS.VSCodeExecutableFile);
}
[JsonIgnore]
public bool IsFleetFound
{
get => !string.IsNullOrEmpty(Native.OS.FleetExecutableFile);
}
[JsonIgnore]
public Models.GitFlow GitFlow
{
@ -291,7 +279,7 @@ namespace SourceGit.ViewModels
{
Native.OS.OpenInVSCode(_fullpath);
}
public void OpenInFleet()
{
Native.OS.OpenInFleet(_fullpath);