refactor: Update submodules individually to avoid failures (#925) (#936)

* refactor: Update submodules individually to avoid failures (#925)

- Remove `--recurse-submodules` flag from the clone command to simplify the cloning process.
- Refactor submodule update logic to handle updating all submodules in a loop and improve progress description handling.

* fix: Parse submodule list even if submodule status fails (#935)

src/Commands/Clone.cs

@@ -12,7 +12,7 @@ namespace SourceGit.Commands
             WorkingDirectory = path;
             TraitErrorAsOutput = true;
             SSHKey = sshKey;
-            Args = "clone --progress --verbose --recurse-submodules ";
+            Args = "clone --progress --verbose ";
 
             if (!string.IsNullOrEmpty(extraArgs))
                 Args += $"{extraArgs} ";

src/Commands/QuerySubmodules.cs

@@ -24,8 +24,6 @@ namespace SourceGit.Commands
         {
             var submodules = new List<Models.Submodule>();
             var rs = ReadToEnd();
-            if (!rs.IsSuccess)
-                return submodules;
 
             var builder = new StringBuilder();
             var lines = rs.StdOut.Split('\n', System.StringSplitOptions.RemoveEmptyEntries);

src/ViewModels/Clone.cs

@@ -127,6 +127,14 @@ namespace SourceGit.ViewModels
                     config.Set("remote.origin.sshkey", _sshKey);
                 }
 
+                // individually update submodule (if any)
+                var submoduleList = new Commands.QuerySubmodules(path).Result();
+                foreach (var submodule in submoduleList)
+                {
+                    var update = new Commands.Submodule(path);
+                    update.Update(submodule.Path, true, true, false, SetProgressDescription);
+                }
+
                 CallUIThread(() =>
                 {
                     var node = Preferences.Instance.FindOrAddNodeByRepositoryPath(path, null, true);

src/ViewModels/UpdateSubmodules.cs

@@ -56,25 +56,24 @@ namespace SourceGit.ViewModels
         {
             _repo.SetWatcherEnabled(false);
 
-            string target = string.Empty;
+            List<string> targets;
             if (_updateAll)
-            {
+                targets = Submodules;
-                ProgressDescription = "Updating submodules ...";
-            }
             else
-            {
+                targets = [SelectedSubmodule];
-                target = SelectedSubmodule;
-                ProgressDescription = $"Updating submodule {target} ...";
-            }
 
             return Task.Run(() =>
             {
-                new Commands.Submodule(_repo.FullPath).Update(
+                foreach (var submodule in targets)
-                    target,
+                {
-                    EnableInit,
+                    ProgressDescription = $"Updating submodule {submodule} ...";
-                    EnableRecursive,
+                    new Commands.Submodule(_repo.FullPath).Update(
-                    EnableRemote,
+                        submodule,
-                    SetProgressDescription);
+                        EnableInit,
+                        EnableRecursive,
+                        EnableRemote,
+                        SetProgressDescription);
+                }
 
                 CallUIThread(() => _repo.SetWatcherEnabled(true));
                 return true;