perf: only update uninited or outdated submodules

Signed-off-by: leo <longshuang@msn.cn>

src/Commands/QueryUpdatableSubmodules.cs

@@ -0,0 +1,40 @@
+using System;
+using System.Collections.Generic;
+using System.Text.RegularExpressions;
+
+namespace SourceGit.Commands
+{
+    public partial class QueryUpdatableSubmodules : Command
+    {
+        [GeneratedRegex(@"^([U\-\+ ])([0-9a-f]+)\s(.*?)(\s\(.*\))?$")]
+        private static partial Regex REG_FORMAT_STATUS();
+
+        public QueryUpdatableSubmodules(string repo)
+        {
+            WorkingDirectory = repo;
+            Context = repo;
+            Args = "submodule status";
+        }
+
+        public List<string> Result()
+        {
+            var submodules = new List<string>();
+            var rs = ReadToEnd();
+
+            var lines = rs.StdOut.Split(['\r', '\n'], StringSplitOptions.RemoveEmptyEntries);
+            foreach (var line in lines)
+            {
+                var match = REG_FORMAT_STATUS().Match(line);
+                if (match.Success)
+                {
+                    var stat = match.Groups[1].Value;
+                    var path = match.Groups[3].Value;
+                    if (!stat.StartsWith(' '))
+                        submodules.Add(path);
+                }
+            }
+
+            return submodules;
+        }
+    }
+}

src/Commands/Submodule.cs

@@ -29,23 +29,7 @@ namespace SourceGit.Commands
             }
         }
 
-        public bool Update(string module, bool init, bool recursive, bool useRemote)
+        public bool Update(List<string> modules, bool init, bool recursive, bool useRemote = false)
-        {
-            Args = "submodule update";
-
-            if (init)
-                Args += " --init";
-            if (recursive)
-                Args += " --recursive";
-            if (useRemote)
-                Args += " --remote";
-            if (!string.IsNullOrEmpty(module))
-                Args += $" -- \"{module}\"";
-
-            return Exec();
-        }
-
-        public bool Update(List<Models.Submodule> modules, bool init, bool recursive, bool useRemote)
         {
             var builder = new StringBuilder();
             builder.Append("submodule update");
@@ -60,7 +44,7 @@ namespace SourceGit.Commands
             {
                 builder.Append(" --");
                 foreach (var module in modules)
-                    builder.Append($" \"{module.Path}\"");
+                    builder.Append($" \"{module}\"");
             }
 
             Args = builder.ToString();

src/ViewModels/Checkout.cs

@@ -74,9 +74,9 @@ namespace SourceGit.ViewModels
                 {
                     if (updateSubmodules)
                     {
-                        var submodules = new Commands.QuerySubmodules(_repo.FullPath).Result();
+                        var submodules = new Commands.QueryUpdatableSubmodules(_repo.FullPath).Result();
                         if (submodules.Count > 0)
-                            new Commands.Submodule(_repo.FullPath).Use(log).Update(submodules, true, true, false);
+                            new Commands.Submodule(_repo.FullPath).Use(log).Update(submodules, true, true);
                     }
 
                     if (needPopStash)

src/ViewModels/CheckoutCommit.cs

@@ -74,9 +74,9 @@ namespace SourceGit.ViewModels
                 {
                     if (updateSubmodules)
                     {
-                        var submodules = new Commands.QuerySubmodules(_repo.FullPath).Result();
+                        var submodules = new Commands.QueryUpdatableSubmodules(_repo.FullPath).Result();
                         if (submodules.Count > 0)
-                            new Commands.Submodule(_repo.FullPath).Use(log).Update(submodules, true, true, false);
+                            new Commands.Submodule(_repo.FullPath).Use(log).Update(submodules, true, true);
                     }
 
                     if (needPop)

src/ViewModels/Clone.cs

@@ -140,9 +140,9 @@ namespace SourceGit.ViewModels
 
                 if (InitAndUpdateSubmodules)
                 {
-                    var submodules = new Commands.QuerySubmodules(path).Result();
+                    var submodules = new Commands.QueryUpdatableSubmodules(path).Result();
                     if (submodules.Count > 0)
-                        new Commands.Submodule(path).Use(log).Update(submodules, true, true, false);
+                        new Commands.Submodule(path).Use(log).Update(submodules, true, true);
                 }
 
                 log.Complete();

src/ViewModels/CreateBranch.cs

@@ -144,9 +144,9 @@ namespace SourceGit.ViewModels
                     {
                         if (updateSubmodules)
                         {
-                            var submodules = new Commands.QuerySubmodules(_repo.FullPath).Result();
+                            var submodules = new Commands.QueryUpdatableSubmodules(_repo.FullPath).Result();
                             if (submodules.Count > 0)
-                                new Commands.Submodule(_repo.FullPath).Use(log).Update(submodules, true, true, false);
+                                new Commands.Submodule(_repo.FullPath).Use(log).Update(submodules, true, true);
                         }
 
                         if (needPopStash)

src/ViewModels/Pull.cs

@@ -153,9 +153,9 @@ namespace SourceGit.ViewModels
                 {
                     if (updateSubmodules)
                     {
-                        var submodules = new Commands.QuerySubmodules(_repo.FullPath).Result();
+                        var submodules = new Commands.QueryUpdatableSubmodules(_repo.FullPath).Result();
                         if (submodules.Count > 0)
-                            new Commands.Submodule(_repo.FullPath).Use(log).Update(submodules, true, true, false);
+                            new Commands.Submodule(_repo.FullPath).Use(log).Update(submodules, true, true);
                     }
 
                     if (needPopStash)

src/ViewModels/UpdateSubmodules.cs

@@ -65,14 +65,9 @@ namespace SourceGit.ViewModels
 
             return Task.Run(() =>
             {
-                foreach (var submodule in targets)
+                new Commands.Submodule(_repo.FullPath)
-                {
+                    .Use(log)
-                    new Commands.Submodule(_repo.FullPath).Use(log).Update(
+                    .Update(targets, EnableInit, EnableRecursive, EnableRemote);
-                        submodule,
-                        EnableInit,
-                        EnableRecursive,
-                        EnableRemote);
-                }
 
                 log.Complete();
                 CallUIThread(() => _repo.SetWatcherEnabled(true));