From 00e56ce9d139da58493f3193eb70ec3d510f2577 Mon Sep 17 00:00:00 2001
From: leo <longshuang@msn.cn>
Date: Fri, 25 Apr 2025 15:56:37 +0800
Subject: [PATCH] fix: `System.NullReferenceException` raised after popup stop
 (success or not) running

Signed-off-by: leo <longshuang@msn.cn>
---
 src/Views/PopupRunningStatus.axaml    |  3 +--
 src/Views/PopupRunningStatus.axaml.cs | 14 ++++----------
 2 files changed, 5 insertions(+), 12 deletions(-)

diff --git a/src/Views/PopupRunningStatus.axaml b/src/Views/PopupRunningStatus.axaml
index a8467415..6a0dbdb4 100644
--- a/src/Views/PopupRunningStatus.axaml
+++ b/src/Views/PopupRunningStatus.axaml
@@ -15,8 +15,7 @@
       <TextBlock Margin="6,0,0,0" FontSize="14" FontWeight="Bold" Text="{DynamicResource Text.Running}"/>
     </StackPanel>
 
-    <TextBlock x:Name="TxtDesc"
-               HorizontalAlignment="Stretch"
+    <TextBlock HorizontalAlignment="Stretch"
                TextWrapping="Wrap"
                FontSize="{Binding Source={x:Static vm:Preferences.Instance}, Path=DefaultFontSize, Converter={x:Static c:DoubleConverters.Decrease}}"
                FontStyle="Italic"
diff --git a/src/Views/PopupRunningStatus.axaml.cs b/src/Views/PopupRunningStatus.axaml.cs
index 007ff71a..8a59d87b 100644
--- a/src/Views/PopupRunningStatus.axaml.cs
+++ b/src/Views/PopupRunningStatus.axaml.cs
@@ -21,17 +21,9 @@ namespace SourceGit.Views
             InitializeComponent();
         }
 
-        protected override void OnLoaded(RoutedEventArgs e)
-        {
-            base.OnLoaded(e);
-
-            if (IsVisible)
-                StartAnim();
-        }
-
         protected override void OnUnloaded(RoutedEventArgs e)
         {
-            StopAnim();
+            _isUnloading = true;
             base.OnUnloaded(e);
         }
 
@@ -41,7 +33,7 @@ namespace SourceGit.Views
 
             if (change.Property == IsVisibleProperty)
             {
-                if (IsVisible)
+                if (IsVisible && !_isUnloading)
                     StartAnim();
                 else
                     StopAnim();
@@ -61,5 +53,7 @@ namespace SourceGit.Views
             Icon.Content = null;
             ProgressBar.IsIndeterminate = false;
         }
+
+        private bool _isUnloading = false;
     }
 }