Commit graph

119 commits

Author SHA1 Message Date
Paul Gauthier
919cfc2359 aider: Replaced all self.console.print() calls with self.io.tool_error() calls with [red] removed from the string.
# Context:
USER: replace all the self.console.print() calls that contain [red] with calls to self.io.tool_error() with [red] removed from the string
ASSISTANT: aider/coder.py
<<<<<<< ORIGINAL
            self.console.print(
                f"[red]This tool will almost certainly fail to work with {main_model}"
            )
=======
            self.io.tool_error(f"This tool will almost certainly fail to work with {main_model}")
>>>>>>> UPDATED

aider/coder.py
<<<<<<< ORIGINAL
            self.console.print("[red]No suitable git repo, will not automatically commit edits.")
=======
            self.io.tool_error("No suitable git repo, will not automatically commit edits.")
>>>>>>> UPDATED

aider/coder.py
<<<<<<< ORIGINAL
            self.console.print("[red]Files are not in a git repo.")
=======
            self.io.tool_error("Files are not in a git repo.")
>>>>>>> UPDATED

aider/coder.py
<<<<<<< ORIGINAL
            self.console.print("[red]Files are in different git repos.")
=======
            self.io.tool_error("Files are in different git repos.")
>>>>>>> UPDATED

aider/coder.py
<<<<<<< ORIGINAL
                self.console.print("[red]Skipped adding new files to the git repo.")
=======
                self.io.tool_error("Skipped adding new files to the git repo.")
>>>>>>> UPDATED

aider/coder.py
<<<<<<< ORIGINAL
            self.console.print("[red]Warning: no changes found in tracked files.")
=======
            self.io.tool_error("Warning: no changes found in tracked files.")
>>>>>>> UPDATED

aider/coder.py
<<<<<<< ORIGINAL
            self.console.print("[red]Malformed ORIGINAL/UPDATE blocks, retrying...")
            self.console.print("[red]", Text(err))
=======
            self.io.tool_error("Malformed ORIGINAL/UPDATE blocks, retrying...")
            self.io.tool_error(Text(err))
>>>>>>> UPDATED

Please note that I couldn't find the `self.io.tool_error()` method in the provided code. You may need to create this method in the appropriate class or provide the correct method name to replace the `self.console.print()` calls.
2023-05-12 13:03:34 -07:00
Paul Gauthier
b7299565f1 refac 2023-05-12 10:53:23 -07:00
Paul Gauthier
0325fc40ac roughed in switch to prompt toolkit for _ask funcs 2023-05-12 08:15:32 -07:00
Paul Gauthier
9a4dfae07a wip 2023-05-12 08:05:57 -07:00
Paul Gauthier
596a6d1ae1 make parent dirs 2023-05-11 23:24:29 -07:00
Paul Gauthier
9ef50d8f3d make dirs for new files 2023-05-11 22:55:26 -07:00
Paul Gauthier
89149b307d aider: Changed fname.touch() to fname.touch(parents=True) to create any missing directories in the path.
# Context:
USER: when calling Path.touch() can we ask it to make missing dirs?
ASSISTANT: Yes, you can use the `parents` parameter in the `touch()` method to create any missing directories. Set `parents=True` to create any missing directories in the path. Here's the change needed in the `aider/coder.py` file:

```python
aider/coder.py
<<<<<<< ORIGINAL
                fname.touch()
=======
                fname.touch(parents=True)
>>>>>>> UPDATED
```
2023-05-11 22:37:59 -07:00
Paul Gauthier
5ddaf55dd2 Merge branch 'main' into pattern 2023-05-11 22:19:12 -07:00
Paul Gauthier
c9ef516bdb cleanup \[ from prompt string which was generating improper escape warnings 2023-05-11 22:19:01 -07:00
Paul Gauthier
52a7c4b786 Merge branch 'main' into pattern 2023-05-11 22:15:39 -07:00
Paul Gauthier
684b0e4964 Provide structured errors to GPT if it generates malformed ORIG/UPD blocks 2023-05-11 22:06:02 -07:00
Paul Gauthier
6686ea1005 Only ask to commit when dirty files are touched 2023-05-11 21:14:40 -07:00
Paul Gauthier
797372c69e refactor orig/upd into utils 2023-05-11 20:57:27 -07:00
Paul Gauthier
f29eaf451b ensure the Live is stopped if exceptions occur 2023-05-11 20:40:07 -07:00
Paul Gauthier
c368e87c9f bugfix, removed abs_fnames=set() from Coder 2023-05-11 20:21:09 -07:00
Paul Gauthier
8a60462167 finished adding --yes 2023-05-11 17:51:50 -07:00
Paul Gauthier
4c97d4e654 Removed confirm_ask and prompt_ask methods and added new implementations with yes flag. 2023-05-11 17:46:54 -07:00
Paul Gauthier
625fd1c3a5 aider: Created new function prompt_ask in Coder class and replaced all calls to Prompt.ask with the new function.
# Context:
USER: make a new func self.prompt_ask which just calls Prompt.ask and returns the result. change all calls to use it.
ASSISTANT: I will create a new function `prompt_ask` in the `Coder` class and replace all calls to `Prompt.ask` with the new function.

```python
aider/coder.py
<<<<<<< ORIGINAL
class Coder:
    abs_fnames = set()

    def confirm_ask(self, question, default=None):
=======
class Coder:
    abs_fnames = set()

    def confirm_ask(self, question, default=None):
        return Confirm.ask(question, console=self.console, default=default)

    def prompt_ask(self, question, default=None):
        return Prompt.ask(question, console=self.console, default=default)
>>>>>>> UPDATED

aider/coder.py
<<<<<<< ORIGINAL
            res = Prompt.ask(
=======
            res = self.prompt_ask(
>>>>>>> UPDATED
                "[bright_black]Commit before the chat proceeds? \[y/n/commit message]",  # noqa: W605 E501
                console=self.console,
                default="y",
            ).strip()
```
2023-05-11 17:46:05 -07:00
Paul Gauthier
428d6f73fc Refactored confirm_ask method to accept None as default and used it in all confirmations. 2023-05-11 17:45:06 -07:00
Paul Gauthier
34c2369380 aider: Created a new function confirm_ask in the Coder class and replaced all calls to Confirm.ask with the new function.
# Context:
USER: make a new func self.confirm_ask which just calls Confirm.ask and returns the result. change all calls to use it.
ASSISTANT: I will create a new function `confirm_ask` in the `Coder` class and replace all calls to `Confirm.ask` with the new function.

```python
aider/coder.py
<<<<<<< ORIGINAL
class Coder:
    abs_fnames = set()
=======
class Coder:
    abs_fnames = set()

    def confirm_ask(self, question, default="y"):
        return Confirm.ask(question, console=self.console, default=default)
>>>>>>> UPDATED

aider/coder.py
<<<<<<< ORIGINAL
            if Confirm.ask("[bright_black]Add them?", console=self.console, default="y"):
=======
            if self.confirm_ask("[bright_black]Add them?"):
>>>>>>> UPDATED

aider/coder.py
<<<<<<< ORIGINAL
            if Confirm.ask("[bright_black]Add {path} to git?", console=self.console, default="y"):
=======
            if self.confirm_ask("[bright_black]Add {path} to git?"):
>>>>>>> UPDATED

aider/coder.py
<<<<<<< ORIGINAL
        ok = Confirm.ask("[bright_black]Add these files?", console=self.console, default="y")
=======
        ok = self.confirm_ask("[bright_black]Add these files?")
>>>>>>> UPDATED
```
2023-05-11 17:43:28 -07:00
Paul Gauthier
0dd35cdaee aider: Added a new argument --yes to always say yes to every confirmation and passed it to the Coder class.
# Context:
USER: add a new arg --yes without env. pass it to Coder and store in self.yes. "Always say yes to every confirmation"
ASSISTANT: To add a new argument `--yes` and pass it to the `Coder` class, we need to make changes in `aider/main.py` and `aider/coder.py`.

In `aider/main.py`, add the new argument `--yes` to the argument parser and pass it to the `Coder` class.

```python
aider/main.py
<<<<<<< ORIGINAL
    parser.add_argument(
        "--show-diffs",
        action="store_true",
        help=f"Show diffs when committing changes (default: False, ${env_prefix}SHOW_DIFFS)",
        default=bool(int(os.environ.get(f"{env_prefix}SHOW_DIFFS", 0))),
    )
=======
    parser.add_argument(
        "--show-diffs",
        action="store_true",
        help=f"Show diffs when committing changes (default: False, ${env_prefix}SHOW_DIFFS)",
        default=bool(int(os.environ.get(f"{env_prefix}SHOW_DIFFS", 0))),
    )
    parser.add_argument(
        "--yes",
        action="store_true",
        help="Always say yes to every confirmation",
    )
>>>>>>> UPDATED
```

```python
aider/main.py
<<<<<<< ORIGINAL
    coder = Coder(args.model, fnames, pretty, args.history_file, args.show_diffs, args.auto_commits)
=======
    coder = Coder(args.model, fnames, pretty, args.history_file, args.show_diffs, args.auto_commits, args.yes)
>>>>>>> UPDATED
```

In `aider/coder.py`, add the `yes` parameter to the `Coder` class and store it in `self.yes`.

```python
aider/coder.py
<<<<<<< ORIGINAL
    def __init__(self, main_model, fnames, pretty, history_file, show_diffs, auto_commits):
=======
    def __init__(self, main_model, fnames, pretty, history_file, show_diffs, auto_commits, yes):
>>>>>>> UPDATED
```

```python
aider/coder.py
<<<<<<< ORIGINAL
        self.show_diffs = show_diffs
=======
        self.show_diffs = show_diffs
        self.yes = yes
>>>>>>> UPDATED
```

Now, the `--yes` argument is added and passed to the `Coder` class. You can use `self.yes` in the `Coder` class to determine if the user wants to always say yes to every confirmation.
2023-05-11 17:41:23 -07:00
Paul Gauthier
ea05c00bd1 wip: Added a check to skip auto commits if auto_commits is False. 2023-05-11 17:09:06 -07:00
Paul Gauthier
0213c4344a Added a try-except block to handle GitCommandError and added a check to skip if current_branch_commit_count is None. 2023-05-11 17:02:37 -07:00
Paul Gauthier
a66cbe216e aider: Refactored aider/coder.py to check if there are any commits on the current branch before running the git diff command.
# Context:
USER: can we check if there are any commits on the current branch? rather than any commits in the entire repo?
ASSISTANT: Sure, we can check if there are any commits on the current branch by comparing the current branch's commit count to zero. Here's the change:

```python
aider/coder.py
<<<<<<< ORIGINAL
    if len(repo.heads) > 0:
        these_diffs = repo.git.diff("HEAD", "--color", "--", relative_fname)
    else:
        these_diffs = ""
=======
    current_branch_commit_count = len(list(repo.iter_commits(repo.active_branch)))
    if current_branch_commit_count > 0:
        these_diffs = repo.git.diff("HEAD", "--color", "--", relative_fname)
    else:
        these_diffs = ""
>>>>>>> UPDATED
```

This will check if there are any commits on the current branch before running the `git diff` command.
2023-05-11 16:58:59 -07:00
Paul Gauthier
0cd5f5b812 aider: Checked if there were any commits in the repo before trying to diff.
# Context:
USER: have get_dirty_files_and_diffs check if there are any commits in the repo before trying to diff
ASSISTANT: To check if there are any commits in the repo before trying to diff, we can use `len(repo.heads)` to get the number of branches in the repo. If there are no branches, it means there are no commits. Here's the change:

```python
aider/coder.py
<<<<<<< ORIGINAL
    these_diffs = repo.git.diff("HEAD", "--color", "--", relative_fname)
=======
    if len(repo.heads) > 0:
        these_diffs = repo.git.diff("HEAD", "--color", "--", relative_fname)
    else:
        these_diffs = ""
>>>>>>> UPDATED
```

This will prevent the `git diff` command from running if there are no commits in the repo.
2023-05-11 16:57:49 -07:00
Paul Gauthier
e6f88394f5 Fixed a bug in coder.py where the git diff command was not properly executed. 2023-05-11 16:57:21 -07:00
Paul Gauthier
8e06300495 aider: Fixed GitCommandError by separating paths from revisions using '--' in get_dirty_files_and_diffs function.
# Context:
USER: Traceback (most recent call last):
  File "/Users/gauthier/tmp/try-aider/.venv/bin/aider", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/Users/gauthier/Projects/aider/aider/main.py", line 77, in main
    coder.run()
  File "/Users/gauthier/Projects/aider/aider/coder.py", line 178, in run
    new_user_message = self.run_loop()
                       ^^^^^^^^^^^^^^^
  File "/Users/gauthier/Projects/aider/aider/coder.py", line 219, in run_loop
    return self.send_new_user_message(inp)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/gauthier/Projects/aider/aider/coder.py", line 264, in send_new_user_message
    res = self.commit(history=self.cur_messages, prefix="aider: ")
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/gauthier/Projects/aider/aider/coder.py", line 482, in commit
    relative_dirty_fnames,diffs = get_dirty_files_and_diffs(self.abs_fnames)
                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/gauthier/Projects/aider/aider/coder.py", line 468, in get_dirty_files_and_diffs
    these_diffs = repo.git.diff("HEAD", "--color", relative_fname)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/gauthier/tmp/try-aider/.venv/lib/python3.11/site-packages/git/cmd.py", line 741, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/gauthier/tmp/try-aider/.venv/lib/python3.11/site-packages/git/cmd.py", line 1315, in _call_process
    return self.execute(call, **exec_kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/gauthier/tmp/try-aider/.venv/lib/python3.11/site-packages/git/cmd.py", line 1109, in execute
    raise GitCommandError(redacted_command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git diff HEAD --color hello.py
  stderr: 'fatal: ambiguous argument 'HEAD': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]''

ASSISTANT: It seems like there is an issue with the `git diff` command in the `get_dirty_files_and_diffs` function. The error occurs because the 'HEAD' argument is ambiguous. To fix this issue, we can separate the paths from the revisions using '--'. Here's the change:

```python
aider/coder.py
<<<<<<< ORIGINAL
    these_diffs = repo.git.diff("HEAD", "--color", relative_fname)
=======
    these_diffs = repo.git.diff("HEAD", "--color", "--", relative_fname)
>>>>>>> UPDATED
```

This should resolve the `GitCommandError` you encountered.
2023-05-11 16:56:28 -07:00
Paul Gauthier
173a91a8c2 Fixed a bug in Coder class where the common root directory was not being set correctly. 2023-05-11 16:54:10 -07:00
Paul Gauthier
46cd8362b6 aider: Replaced "_" with the current working directory in find_common_root.
# Context:
USER: in find_common_root replace _ with the cwd
ASSISTANT: ```python
aider/coder.py
<<<<<<< ORIGINAL
        if not self.abs_fnames:
            self.root = _
=======
        if not self.abs_fnames:
            self.root = os.getcwd()
>>>>>>> UPDATED
```
2023-05-11 16:53:19 -07:00
Paul Gauthier
be882158e4 Added auto_commits parameter to Coder class constructor. 2023-05-11 15:46:02 -07:00
Paul Gauthier
b018eade37 aider: Added auto_commits as a new argument to the Coder() class and updated main() function to pass the argument.
# Context:
USER: add auto_commits as a new arg to Coder(). assign it to self.auto_commit
ASSISTANT: To add `auto_commits` as a new argument to the `Coder()` class and assign it to `self.auto_commit`, you need to update the `__init__` method in the `aider/coder.py` file:

```python
aider/coder.py
<<<<<<< ORIGINAL
    def __init__(self, main_model, fnames, pretty, history_file, show_diffs):
=======
    def __init__(self, main_model, fnames, pretty, history_file, show_diffs, auto_commits):
>>>>>>> UPDATED
        self.history_file = history_file

        # ... (rest of the code remains unchanged)

        self.show_diffs = show_diffs
<<<<<<< ORIGINAL
=======
        self.auto_commit = auto_commits
>>>>>>> UPDATED
```

Then, update the `main()` function in the `aider/main.py` file to pass the `auto_commits` argument when creating a new `Coder` instance:

```python
aider/main.py
<<<<<<< ORIGINAL
    coder = Coder(args.model, fnames, pretty, args.history_file, args.show_diffs)
=======
    coder = Coder(args.model, fnames, pretty, args.history_file, args.show_diffs, args.auto_commits)
>>>>>>> UPDATED
    coder.commit(ask=True, prefix="wip: ", which="repo_files")

    # ... (rest of the code remains unchanged)
```
2023-05-11 15:45:31 -07:00
Paul Gauthier
e5abb97eaa wip: Changed get_dirty_files to get_dirty_files_and_diffs to also return diffs. 2023-05-11 09:39:01 -07:00
Paul Gauthier
fe0f8928a2 honor the user provided /commit message 2023-05-11 09:37:20 -07:00
Paul Gauthier
db2e062634 wip: Added methods to get context from history and commit message. 2023-05-11 09:36:34 -07:00
Paul Gauthier
1f4a54cf01 Fixed a bug where the commit command was not being executed when the repo was dirty. 2023-05-11 09:29:11 -07:00
Paul Gauthier
34fac7b4b9 Fixed a bug where the commit command was being triggered when the repo was dirty. 2023-05-11 09:28:36 -07:00
Paul Gauthier
0434f71c9f wip: Refactor console message for uncommitted changes in coder.py. 2023-05-11 09:26:55 -07:00
Paul Gauthier
23a0339a15 Removed dump function call from coder.py. 2023-05-11 09:25:09 -07:00
Paul Gauthier
4d263eda10 Removed get_last_modified method and replaced last_modified check with repo.is_dirty. 2023-05-11 09:24:32 -07:00
Paul Gauthier
14b45f40f6 finishing support for which=repo_files 2023-05-11 09:22:51 -07:00
Paul Gauthier
6e68562cd0 fixed reference to repo var 2023-05-11 09:15:12 -07:00
Paul Gauthier
cee1dfd3b9 aider: Added an elif clause for which == "chat_files" and a final else clause to raise a ValueError if the value of which is not valid.
# Context:
USER: nice! in the change the else: to elseif which==chat_files and throw a valueerror as a final else clause
ASSISTANT: To update the `commit()` function with the requested changes, we will modify the `if` statement to include an `elif` clause for `which == "chat_files"` and add a final `else` clause to raise a `ValueError`.

```python
aider/coder.py
<<<<<<< ORIGINAL
        if which == "repo_files":
            all_files = [os.path.join(self.root, f) for f in self.get_all_relative_files()]
            dirty_fnames, relative_dirty_fnames = get_dirty_files(all_files)
        else:
            dirty_fnames, relative_dirty_fnames = get_dirty_files(self.abs_fnames)
=======
        if which == "repo_files":
            all_files = [os.path.join(self.root, f) for f in self.get_all_relative_files()]
            dirty_fnames, relative_dirty_fnames = get_dirty_files(all_files)
        elif which == "chat_files":
            dirty_fnames, relative_dirty_fnames = get_dirty_files(self.abs_fnames)
        else:
            raise ValueError(f"Invalid value for 'which': {which}")
>>>>>>> UPDATED
```

This change adds an `elif` clause for `which == "chat_files"` and a final `else` clause to raise a `ValueError` if the value of `which` is not valid.
2023-05-11 09:13:25 -07:00
Paul Gauthier
da40aaa6ca aider: Updated commit() to handle which="repo_files", committing all pending changes to all the files in the repo.
# Context:
USER: update commit() to handle which="repo_files". in that case, it should commit all pending changes to all the files in the repo, not just the chat files in self.abs_fnames
ASSISTANT: To update the `commit()` function to handle `which="repo_files"`, we will modify the function to commit all pending changes to all the files in the repo when `which` is set to `"repo_files"`.

```python
aider/coder.py
<<<<<<< ORIGINAL
    def commit(self, history=None, prefix=None, ask=False, message=None, which="chat_files"):
=======
    def commit(self, history=None, prefix=None, ask=False, message=None, which="chat_files"):
        def get_dirty_files(file_list):
            dirty_files = []
            relative_dirty_files = []
            for fname in file_list:
                relative_fname = os.path.relpath(fname, repo.working_tree_dir)
                if self.pretty:
                    these_diffs = repo.git.diff("HEAD", "--color", relative_fname)
                else:
                    these_diffs = repo.git.diff("HEAD", relative_fname)

                if these_diffs:
                    dirty_files.append(fname)
                    relative_dirty_files.append(relative_fname)

            return dirty_files, relative_dirty_files

        if which == "repo_files":
            all_files = [os.path.join(self.root, f) for f in self.get_all_relative_files()]
            dirty_fnames, relative_dirty_fnames = get_dirty_files(all_files)
        else:
            dirty_fnames, relative_dirty_fnames = get_dirty_files(self.abs_fnames)
>>>>>>> UPDATED
```

This change adds a new function `get_dirty_files()` inside the `commit()` function to get the dirty files and their relative paths based on the provided file list. Then, we check the value of `which` and set the `dirty_fnames` and `relative_dirty_fnames` accordingly. If `which` is `"repo_files"`, we use all the files in the repo; otherwise, we use the chat files in `self.abs_fnames`.
2023-05-11 09:11:48 -07:00
Paul Gauthier
0a7c5d1a78 wip: Removed unnecessary lines of code in coder.py. 2023-05-11 06:03:11 -07:00
Paul Gauthier
e875d0ca7f Refactor loop to use class attribute instead of parameter. 2023-05-11 06:02:21 -07:00
Paul Gauthier
a614179209 fix logic when there is no git repo 2023-05-11 06:01:37 -07:00
Paul Gauthier
94548b712e show_send_output should respect silent 2023-05-10 22:12:13 -07:00
Paul Gauthier
579d28dcf0 remove debug output 2023-05-10 22:08:40 -07:00
Paul Gauthier
a3fa9d46df remove debug output 2023-05-10 22:06:50 -07:00
Paul Gauthier
f026f1eeeb sniff when GPT mentions files that are not in the chat, prompt the user to add them 2023-05-10 22:05:00 -07:00