Commit graph

16 commits

Author SHA1 Message Date
Paul Gauthier
486c5ab224 build: don't login to docker hub for docker build test 2024-09-24 13:02:31 -07:00
Paul Gauthier (aider)
5d80e11e5b feat: Add Docker full image build to CI workflow 2024-09-21 13:59:50 -07:00
Paul Gauthier (aider)
971f317d3d build: Add HISTORY.md to ignore list in GitHub Actions workflows 2024-08-27 07:14:01 -07:00
Paul Gauthier
8e20d762f5 don't run jobs if just website is modified 2024-07-06 15:21:34 -03:00
Paul Gauthier
9de32c88c3 ignore README for actions 2024-06-05 16:14:21 -07:00
Paul Gauthier
0effca7e88 removed extra paths-ignore 2024-06-05 15:58:07 -07:00
Paul Gauthier
cc8151e3b2 aider: Add paths-ignore condition under the push event in workflows to prevent running if only files in the website/ subtree are changed.
# Aider chat conversation:

USER: do we need that under the `push:` too?

ASSISTANT: Yes, we should add the `paths-ignore` condition under the `push` event as well to ensure the workflows do not run if only files in the `website/` subtree are changed.

Here are the updated *SEARCH/REPLACE* blocks:

.github/workflows/windows-tests.yml
```yaml
<<<<<<< SEARCH
  pull_request:
=======
  pull_request:
    paths-ignore:
      - 'website/**'
>>>>>>> REPLACE
```

.github/workflows/windows-tests.yml
```yaml
<<<<<<< SEARCH
  push:
=======
  push:
    paths-ignore:
      - 'website/**'
>>>>>>> REPLACE
```

.github/workflows/docker-build-test.yml
```yaml
<<<<<<< SEARCH
  pull_request:
=======
  pull_request:
    paths-ignore:
      - 'website/**'
>>>>>>> REPLACE
```

.github/workflows/docker-build-test.yml
```yaml
<<<<<<< SEARCH
  push:
=======
  push:
    paths-ignore:
      - 'website/**'
>>>>>>> REPLACE
```

.github/workflows/ubuntu-tests.yml
```yaml
<<<<<<< SEARCH
  pull_request:
=======
  pull_request:
    paths-ignore:
      - 'website/**'
>>>>>>> REPLACE
```

.github/workflows/ubuntu-tests.yml
```yaml
<<<<<<< SEARCH
  push:
=======
  push:
    paths-ignore:
      - 'website/**'
>>>>>>> REPLACE
```
2024-06-05 15:57:29 -07:00
Paul Gauthier
a10077f6c9 aider: Ensure workflows do not run if only files in the website/ subtree are changed.
# Aider chat conversation:

USER: these workflows currently run on any changes to the main branch; they don't need to run if only files in the wubsite/ subtree are changed

ASSISTANT: To ensure the workflows do not run if only files in the `website/` subtree are changed, we can add a `paths-ignore` condition to each workflow. Here are the changes:

.github/workflows/windows-tests.yml
```yaml
<<<<<<< SEARCH
  pull_request:
=======
  pull_request:
    paths-ignore:
      - 'website/**'
>>>>>>> REPLACE
```

.github/workflows/docker-build-test.yml
```yaml
<<<<<<< SEARCH
  pull_request:
=======
  pull_request:
    paths-ignore:
      - 'website/**'
>>>>>>> REPLACE
```

.github/workflows/ubuntu-tests.yml
```yaml
<<<<<<< SEARCH
  pull_request:
=======
  pull_request:
    paths-ignore:
      - 'website/**'
>>>>>>> REPLACE
```
2024-06-05 15:56:58 -07:00
Paul Gauthier
3e153cc7fa upgrade actions 2024-04-18 16:41:45 -07:00
Paul Gauthier
531ea58eb6 use env to test secrets 2023-12-31 10:12:05 -08:00
Paul Gauthier
9d4fcff921 Updated docker-build-test workflow to always check for DockerHub credentials before building. 2023-12-31 10:08:35 -08:00
Paul Gauthier
1b43dddec5 aider: This change corrected the conditional expression for the Docker login step by removing the incorrect ${{ }} around secrets.DOCKERHUB_USERNAME and secrets.DOCKERHUB_PASSWORD and adding a check for the github.event_name to ensure that the login step is only executed when it's not a pull request or when the secrets are available.
# Aider chat conversation:

USER: The workflow is not valid. .github/workflows/docker-build-test.yml (Line: 30, Col: 11): Unrecognized named-value: 'secrets'. Located at position 1 within expression: secrets.DOCKERHUB_USERNAME

ASSISTANT: ```diff
--- .github/workflows/docker-build-test.yml
+++ .github/workflows/docker-build-test.yml
@@ ... @@
       uses: docker/login-action@v3
       with:
         username: ${{ secrets.DOCKERHUB_USERNAME }}
         password: ${{ secrets.DOCKERHUB_PASSWORD }}
-      if: ${{ secrets.DOCKERHUB_USERNAME }} && ${{ secrets.DOCKERHUB_PASSWORD }}
+      if: ${{ github.event_name != 'pull_request' || (secrets.DOCKERHUB_USERNAME && secrets.DOCKERHUB_PASSWORD) }}
```

This change corrects the conditional expression for the Docker login step by removing the incorrect `${{ }}` around `secrets.DOCKERHUB_USERNAME` and `secrets.DOCKERHUB_PASSWORD` and adding a check for the `github.event_name` to ensure that the login step is only executed when it's not a pull request or when the secrets are available.
2023-12-31 10:06:59 -08:00
Joshua Vial
62da17e333 aider: Adjust DockerHub login action to complete without failing if credentials are not present.
# Aider chat conversation:

USER: please adjust this github action file so it will complete without failing if the dockerhub_username or password are not there

ASSISTANT: ```diff
--- .github/workflows/docker-build-test.yml
+++ .github/workflows/docker-build-test.yml
@@ ... @@
     - name: Login to DockerHub
       uses: docker/login-action@v3
       with:
         username: ${{ secrets.DOCKERHUB_USERNAME }}
         password: ${{ secrets.DOCKERHUB_PASSWORD }}
+      if: ${{ secrets.DOCKERHUB_USERNAME }} && ${{ secrets.DOCKERHUB_PASSWORD }}
```
2023-12-28 11:07:35 +13:00
Paul Gauthier
c9aa36d7b6 Put build-essential back into dockerfile 2023-10-31 14:52:04 -07:00
Paul Gauthier
702fc0c6ea restore release.yml, do multi arch build in docker-build-test.yml 2023-10-31 14:48:37 -07:00
Paul Gauthier
3eaa9671be Just test building the docker image 2023-10-30 09:15:16 -07:00
Renamed from .github/workflows/docker-build-and-test.yml (Browse further)