Commit graph

5866 commits

Author SHA1 Message Date
Paul Gauthier
85515b4788 Refactored the code to use a new io tool method and removed the tool_error method. 2023-05-12 13:37:22 -07:00
Paul Gauthier
91f23f3700 aider: Replaced self.console.print() calls with self.io.tool_error() calls for [red] strings and added missing instances.
# Context:
USER: replace all the self.console.print() calls that contain [red] with calls to self.io.tool_error() with [red] removed from the string
ASSISTANT: I apologize for the confusion earlier. I see that the changes have already been committed. There is no need to make the same changes again. If you have any other requests or need assistance with the code, please let me know.
USER: you missed 2 that contain " edit to {path}"
ASSISTANT: You're right, I missed those. Here are the changes for the remaining instances:

aider/coder.py
<<<<<<< ORIGINAL
            self.console.print(f"[red]Skipping edit to {path}")
=======
            self.io.tool_error(f"Skipping edit to {path}")
>>>>>>> UPDATED

aider/coder.py
<<<<<<< ORIGINAL
            self.console.print(f"[red]Failed to apply edit to {path}")
=======
            self.io.tool_error(f"Failed to apply edit to {path}")
>>>>>>> UPDATED
2023-05-12 13:32:39 -07:00
Paul Gauthier
fca8ea3c21 aider: Replaced all self.console.print() calls with self.io.tool_error() calls.
# Context:
USER: replace all the self.console.print() calls that contain [red] with calls to self.io.tool_error() with [red] removed from the string
ASSISTANT: aider/coder.py
<<<<<<< ORIGINAL
            self.console.print("[red]^C again to quit")
=======
            self.io.tool_error("^C again to quit")
>>>>>>> UPDATED

aider/coder.py
<<<<<<< ORIGINAL
            self.io.tool_error("Malformed ORIGINAL/UPDATE blocks, retrying...")
            self.io.tool_error(err)
=======
            self.io.tool_error("Malformed ORIGINAL/UPDATE blocks, retrying...")
            self.io.tool_error(str(err))
>>>>>>> UPDATED

aider/coder.py
<<<<<<< ORIGINAL
            self.console.print("[red]Unable to get commit message from gpt-3.5-turbo. Use /commit to try again.\n")
=======
            self.io.tool_error("Unable to get commit message from gpt-3.5-turbo. Use /commit to try again.")
>>>>>>> UPDATED

aider/coder.py
<<<<<<< ORIGINAL
            self.console.print("[red]Skipped commmit.")
=======
            self.io.tool_error("Skipped commmit.")
>>>>>>> UPDATED
2023-05-12 13:31:32 -07:00
Paul Gauthier
92e091f5a6 fix bug if ORIG/UPD block is missing trailing newline; added test 2023-05-12 13:30:39 -07:00
Paul Gauthier
1d7fffe8ab wip: Refactor Input class to InputOutput and add tool_error method. 2023-05-12 13:17:37 -07:00
Paul Gauthier
57f1b3139a wip: Removed unused import and changed Text object to string. 2023-05-12 13:12:50 -07:00
Paul Gauthier
919cfc2359 aider: Replaced all self.console.print() calls with self.io.tool_error() calls with [red] removed from the string.
# Context:
USER: replace all the self.console.print() calls that contain [red] with calls to self.io.tool_error() with [red] removed from the string
ASSISTANT: aider/coder.py
<<<<<<< ORIGINAL
            self.console.print(
                f"[red]This tool will almost certainly fail to work with {main_model}"
            )
=======
            self.io.tool_error(f"This tool will almost certainly fail to work with {main_model}")
>>>>>>> UPDATED

aider/coder.py
<<<<<<< ORIGINAL
            self.console.print("[red]No suitable git repo, will not automatically commit edits.")
=======
            self.io.tool_error("No suitable git repo, will not automatically commit edits.")
>>>>>>> UPDATED

aider/coder.py
<<<<<<< ORIGINAL
            self.console.print("[red]Files are not in a git repo.")
=======
            self.io.tool_error("Files are not in a git repo.")
>>>>>>> UPDATED

aider/coder.py
<<<<<<< ORIGINAL
            self.console.print("[red]Files are in different git repos.")
=======
            self.io.tool_error("Files are in different git repos.")
>>>>>>> UPDATED

aider/coder.py
<<<<<<< ORIGINAL
                self.console.print("[red]Skipped adding new files to the git repo.")
=======
                self.io.tool_error("Skipped adding new files to the git repo.")
>>>>>>> UPDATED

aider/coder.py
<<<<<<< ORIGINAL
            self.console.print("[red]Warning: no changes found in tracked files.")
=======
            self.io.tool_error("Warning: no changes found in tracked files.")
>>>>>>> UPDATED

aider/coder.py
<<<<<<< ORIGINAL
            self.console.print("[red]Malformed ORIGINAL/UPDATE blocks, retrying...")
            self.console.print("[red]", Text(err))
=======
            self.io.tool_error("Malformed ORIGINAL/UPDATE blocks, retrying...")
            self.io.tool_error(Text(err))
>>>>>>> UPDATED

Please note that I couldn't find the `self.io.tool_error()` method in the provided code. You may need to create this method in the appropriate class or provide the correct method name to replace the `self.console.print()` calls.
2023-05-12 13:03:34 -07:00
Paul Gauthier
b7299565f1 refac 2023-05-12 10:53:23 -07:00
Paul Gauthier
0325fc40ac roughed in switch to prompt toolkit for _ask funcs 2023-05-12 08:15:32 -07:00
Paul Gauthier
9a4dfae07a wip 2023-05-12 08:05:57 -07:00
Paul Gauthier
0c3b772172 prompt eng for new files 2023-05-11 23:24:38 -07:00
Paul Gauthier
596a6d1ae1 make parent dirs 2023-05-11 23:24:29 -07:00
Paul Gauthier
d45b7ae752 handle filenames above the triple quotes 2023-05-11 22:59:02 -07:00
Paul Gauthier
9ef50d8f3d make dirs for new files 2023-05-11 22:55:26 -07:00
Paul Gauthier
89149b307d aider: Changed fname.touch() to fname.touch(parents=True) to create any missing directories in the path.
# Context:
USER: when calling Path.touch() can we ask it to make missing dirs?
ASSISTANT: Yes, you can use the `parents` parameter in the `touch()` method to create any missing directories. Set `parents=True` to create any missing directories in the path. Here's the change needed in the `aider/coder.py` file:

```python
aider/coder.py
<<<<<<< ORIGINAL
                fname.touch()
=======
                fname.touch(parents=True)
>>>>>>> UPDATED
```
2023-05-11 22:37:59 -07:00
Paul Gauthier
5ddaf55dd2 Merge branch 'main' into pattern 2023-05-11 22:19:12 -07:00
Paul Gauthier
c9ef516bdb cleanup \[ from prompt string which was generating improper escape warnings 2023-05-11 22:19:01 -07:00
Paul Gauthier
52a7c4b786 Merge branch 'main' into pattern 2023-05-11 22:15:39 -07:00
Paul Gauthier
6e4f17d377 cleanup 2023-05-11 22:06:32 -07:00
Paul Gauthier
684b0e4964 Provide structured errors to GPT if it generates malformed ORIG/UPD blocks 2023-05-11 22:06:02 -07:00
Paul Gauthier
6686ea1005 Only ask to commit when dirty files are touched 2023-05-11 21:14:40 -07:00
Paul Gauthier
ae41782cb4 wip 2023-05-11 21:05:15 -07:00
Paul Gauthier
797372c69e refactor orig/upd into utils 2023-05-11 20:57:27 -07:00
Paul Gauthier
5e593eb631 handle no args properly 2023-05-11 20:56:09 -07:00
Paul Gauthier
ed6ceae544 cleanup 2023-05-11 20:45:20 -07:00
Paul Gauthier
dabda6c5ea aider: Replaced console.reset() with reset_terminal() from rich.console module to reset the terminal without clearing the screen.
# Context:
USER: AttributeError: 'Console' object has no attribute 'reset'
ASSISTANT: I apologize for the confusion. It seems I made a mistake in my previous suggestion. The `rich` library does not have a `reset()` method for the `Console` object. Instead, you can use the `reset_terminal()` function from the `rich.console` module. Here's the change for `aider/main.py`:

```python
aider/main.py
<<<<<<< ORIGINAL
from rich.console import Console
=======
from rich.console import Console, reset_terminal
>>>>>>> UPDATED

aider/main.py
<<<<<<< ORIGINAL
    console = Console()
    console.reset()
=======
    reset_terminal()
>>>>>>> UPDATED
```

This change imports the `reset_terminal()` function from the `rich.console` module and replaces the `console.reset()` call with `reset_terminal()` at the end of the `main()` function to reset the terminal without clearing the screen.
2023-05-11 20:44:46 -07:00
Paul Gauthier
0ef2790464 aider: Replaced console.clear() with console.reset() to disable funky terminal modes.
# Context:
USER: i don't want to clear the screen. just disable any funky terminal modes
ASSISTANT: I apologize for the confusion. If you want to disable any funky terminal modes without clearing the screen, you can use the `rich` library's `reset()` method. Here's the change for `aider/main.py`:

```python
aider/main.py
<<<<<<< ORIGINAL
    coder.run()
    console = Console()
    console.clear()
=======
    coder.run()
    console = Console()
    console.reset()
>>>>>>> UPDATED
```

This change replaces the `console.clear()` call with `console.reset()` at the end of the `main()` function to reset the terminal without clearing the screen.
2023-05-11 20:44:01 -07:00
Paul Gauthier
71116a771b aider: Added rich library to reset the terminal at the end of main() function.
# Context:
USER: at the end of main() reset the terminal
ASSISTANT: I need to see the contents of `aider/main.py` to make the requested changes. Please provide the content of that file.
USER: Please note that I shared content of these additional files: aider/main.py
ASSISTANT: I apologize for the oversight. I see the content of `aider/main.py` now. To reset the terminal at the end of the `main()` function, you can use the `os.system()` function with the appropriate command for your operating system. Here's the change for `aider/main.py`:

```python
aider/main.py
<<<<<<< ORIGINAL

^C KeyboardInterrupt
USER: no i need pure python. can rich do it?
ASSISTANT: Yes, you can use the `rich` library to reset the terminal using pure Python. First, you need to import the `Console` class from the `rich.console` module. Then, create a `Console` instance and call its `clear()` method at the end of the `main()` function. Here's the change for `aider/main.py`:

```python
aider/main.py
<<<<<<< ORIGINAL
import os
import sys
import argparse
from dotenv import load_dotenv
from aider.coder import Coder
=======
import os
import sys
import argparse
from dotenv import load_dotenv
from aider.coder import Coder
from rich.console import Console
>>>>>>> UPDATED

aider/main.py
<<<<<<< ORIGINAL
    coder.run()
=======
    coder.run()
    console = Console()
    console.clear()
>>>>>>> UPDATED
```

This change imports the `Console` class from the `rich.console` module and adds the `console.clear()` call at the end of the `main()` function to reset the terminal.
2023-05-11 20:43:11 -07:00
Paul Gauthier
f29eaf451b ensure the Live is stopped if exceptions occur 2023-05-11 20:40:07 -07:00
Paul Gauthier
d44f732d3b main should use argv if args not provided 2023-05-11 20:34:46 -07:00
Paul Gauthier
c368e87c9f bugfix, removed abs_fnames=set() from Coder 2023-05-11 20:21:09 -07:00
Paul Gauthier
8a60462167 finished adding --yes 2023-05-11 17:51:50 -07:00
Paul Gauthier
4c97d4e654 Removed confirm_ask and prompt_ask methods and added new implementations with yes flag. 2023-05-11 17:46:54 -07:00
Paul Gauthier
625fd1c3a5 aider: Created new function prompt_ask in Coder class and replaced all calls to Prompt.ask with the new function.
# Context:
USER: make a new func self.prompt_ask which just calls Prompt.ask and returns the result. change all calls to use it.
ASSISTANT: I will create a new function `prompt_ask` in the `Coder` class and replace all calls to `Prompt.ask` with the new function.

```python
aider/coder.py
<<<<<<< ORIGINAL
class Coder:
    abs_fnames = set()

    def confirm_ask(self, question, default=None):
=======
class Coder:
    abs_fnames = set()

    def confirm_ask(self, question, default=None):
        return Confirm.ask(question, console=self.console, default=default)

    def prompt_ask(self, question, default=None):
        return Prompt.ask(question, console=self.console, default=default)
>>>>>>> UPDATED

aider/coder.py
<<<<<<< ORIGINAL
            res = Prompt.ask(
=======
            res = self.prompt_ask(
>>>>>>> UPDATED
                "[bright_black]Commit before the chat proceeds? \[y/n/commit message]",  # noqa: W605 E501
                console=self.console,
                default="y",
            ).strip()
```
2023-05-11 17:46:05 -07:00
Paul Gauthier
428d6f73fc Refactored confirm_ask method to accept None as default and used it in all confirmations. 2023-05-11 17:45:06 -07:00
Paul Gauthier
34c2369380 aider: Created a new function confirm_ask in the Coder class and replaced all calls to Confirm.ask with the new function.
# Context:
USER: make a new func self.confirm_ask which just calls Confirm.ask and returns the result. change all calls to use it.
ASSISTANT: I will create a new function `confirm_ask` in the `Coder` class and replace all calls to `Confirm.ask` with the new function.

```python
aider/coder.py
<<<<<<< ORIGINAL
class Coder:
    abs_fnames = set()
=======
class Coder:
    abs_fnames = set()

    def confirm_ask(self, question, default="y"):
        return Confirm.ask(question, console=self.console, default=default)
>>>>>>> UPDATED

aider/coder.py
<<<<<<< ORIGINAL
            if Confirm.ask("[bright_black]Add them?", console=self.console, default="y"):
=======
            if self.confirm_ask("[bright_black]Add them?"):
>>>>>>> UPDATED

aider/coder.py
<<<<<<< ORIGINAL
            if Confirm.ask("[bright_black]Add {path} to git?", console=self.console, default="y"):
=======
            if self.confirm_ask("[bright_black]Add {path} to git?"):
>>>>>>> UPDATED

aider/coder.py
<<<<<<< ORIGINAL
        ok = Confirm.ask("[bright_black]Add these files?", console=self.console, default="y")
=======
        ok = self.confirm_ask("[bright_black]Add these files?")
>>>>>>> UPDATED
```
2023-05-11 17:43:28 -07:00
Paul Gauthier
0dd35cdaee aider: Added a new argument --yes to always say yes to every confirmation and passed it to the Coder class.
# Context:
USER: add a new arg --yes without env. pass it to Coder and store in self.yes. "Always say yes to every confirmation"
ASSISTANT: To add a new argument `--yes` and pass it to the `Coder` class, we need to make changes in `aider/main.py` and `aider/coder.py`.

In `aider/main.py`, add the new argument `--yes` to the argument parser and pass it to the `Coder` class.

```python
aider/main.py
<<<<<<< ORIGINAL
    parser.add_argument(
        "--show-diffs",
        action="store_true",
        help=f"Show diffs when committing changes (default: False, ${env_prefix}SHOW_DIFFS)",
        default=bool(int(os.environ.get(f"{env_prefix}SHOW_DIFFS", 0))),
    )
=======
    parser.add_argument(
        "--show-diffs",
        action="store_true",
        help=f"Show diffs when committing changes (default: False, ${env_prefix}SHOW_DIFFS)",
        default=bool(int(os.environ.get(f"{env_prefix}SHOW_DIFFS", 0))),
    )
    parser.add_argument(
        "--yes",
        action="store_true",
        help="Always say yes to every confirmation",
    )
>>>>>>> UPDATED
```

```python
aider/main.py
<<<<<<< ORIGINAL
    coder = Coder(args.model, fnames, pretty, args.history_file, args.show_diffs, args.auto_commits)
=======
    coder = Coder(args.model, fnames, pretty, args.history_file, args.show_diffs, args.auto_commits, args.yes)
>>>>>>> UPDATED
```

In `aider/coder.py`, add the `yes` parameter to the `Coder` class and store it in `self.yes`.

```python
aider/coder.py
<<<<<<< ORIGINAL
    def __init__(self, main_model, fnames, pretty, history_file, show_diffs, auto_commits):
=======
    def __init__(self, main_model, fnames, pretty, history_file, show_diffs, auto_commits, yes):
>>>>>>> UPDATED
```

```python
aider/coder.py
<<<<<<< ORIGINAL
        self.show_diffs = show_diffs
=======
        self.show_diffs = show_diffs
        self.yes = yes
>>>>>>> UPDATED
```

Now, the `--yes` argument is added and passed to the `Coder` class. You can use `self.yes` in the `Coder` class to determine if the user wants to always say yes to every confirmation.
2023-05-11 17:41:23 -07:00
Paul Gauthier
490a6999fb allow main() w/o args 2023-05-11 17:28:03 -07:00
Paul Gauthier
88b48bd04b noop 2023-05-11 17:22:58 -07:00
Paul Gauthier
7c50fd654a aider: Passed argv to main() and parse_args().
# Context:
USER: have __main__ pass argv to main(). then pass that into parse_args
ASSISTANT: To pass `argv` to `main()` and then pass it to `parse_args`, you need to modify the `main()` function definition to accept an argument and pass `sys.argv[1:]` to it. Then, pass the argument to `parse_args()`.

Here's the change:

```python
aider/main.py
<<<<<<< ORIGINAL
def main():
=======
def main(argv):
>>>>>>> UPDATED

aider/main.py
<<<<<<< ORIGINAL
    args = parser.parse_args()
=======
    args = parser.parse_args(argv)
>>>>>>> UPDATED

aider/main.py
<<<<<<< ORIGINAL
    status = main()
=======
    status = main(sys.argv[1:])
>>>>>>> UPDATED
```
2023-05-11 17:16:40 -07:00
Paul Gauthier
6133eb61c1 fix tests and bug 2023-05-11 17:15:19 -07:00
Paul Gauthier
6dd586c753 init testing 2023-05-11 17:11:22 -07:00
Paul Gauthier
ea05c00bd1 wip: Added a check to skip auto commits if auto_commits is False. 2023-05-11 17:09:06 -07:00
Paul Gauthier
0213c4344a Added a try-except block to handle GitCommandError and added a check to skip if current_branch_commit_count is None. 2023-05-11 17:02:37 -07:00
Paul Gauthier
a66cbe216e aider: Refactored aider/coder.py to check if there are any commits on the current branch before running the git diff command.
# Context:
USER: can we check if there are any commits on the current branch? rather than any commits in the entire repo?
ASSISTANT: Sure, we can check if there are any commits on the current branch by comparing the current branch's commit count to zero. Here's the change:

```python
aider/coder.py
<<<<<<< ORIGINAL
    if len(repo.heads) > 0:
        these_diffs = repo.git.diff("HEAD", "--color", "--", relative_fname)
    else:
        these_diffs = ""
=======
    current_branch_commit_count = len(list(repo.iter_commits(repo.active_branch)))
    if current_branch_commit_count > 0:
        these_diffs = repo.git.diff("HEAD", "--color", "--", relative_fname)
    else:
        these_diffs = ""
>>>>>>> UPDATED
```

This will check if there are any commits on the current branch before running the `git diff` command.
2023-05-11 16:58:59 -07:00
Paul Gauthier
0cd5f5b812 aider: Checked if there were any commits in the repo before trying to diff.
# Context:
USER: have get_dirty_files_and_diffs check if there are any commits in the repo before trying to diff
ASSISTANT: To check if there are any commits in the repo before trying to diff, we can use `len(repo.heads)` to get the number of branches in the repo. If there are no branches, it means there are no commits. Here's the change:

```python
aider/coder.py
<<<<<<< ORIGINAL
    these_diffs = repo.git.diff("HEAD", "--color", "--", relative_fname)
=======
    if len(repo.heads) > 0:
        these_diffs = repo.git.diff("HEAD", "--color", "--", relative_fname)
    else:
        these_diffs = ""
>>>>>>> UPDATED
```

This will prevent the `git diff` command from running if there are no commits in the repo.
2023-05-11 16:57:49 -07:00
Paul Gauthier
e6f88394f5 Fixed a bug in coder.py where the git diff command was not properly executed. 2023-05-11 16:57:21 -07:00
Paul Gauthier
8e06300495 aider: Fixed GitCommandError by separating paths from revisions using '--' in get_dirty_files_and_diffs function.
# Context:
USER: Traceback (most recent call last):
  File "/Users/gauthier/tmp/try-aider/.venv/bin/aider", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/Users/gauthier/Projects/aider/aider/main.py", line 77, in main
    coder.run()
  File "/Users/gauthier/Projects/aider/aider/coder.py", line 178, in run
    new_user_message = self.run_loop()
                       ^^^^^^^^^^^^^^^
  File "/Users/gauthier/Projects/aider/aider/coder.py", line 219, in run_loop
    return self.send_new_user_message(inp)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/gauthier/Projects/aider/aider/coder.py", line 264, in send_new_user_message
    res = self.commit(history=self.cur_messages, prefix="aider: ")
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/gauthier/Projects/aider/aider/coder.py", line 482, in commit
    relative_dirty_fnames,diffs = get_dirty_files_and_diffs(self.abs_fnames)
                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/gauthier/Projects/aider/aider/coder.py", line 468, in get_dirty_files_and_diffs
    these_diffs = repo.git.diff("HEAD", "--color", relative_fname)
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/gauthier/tmp/try-aider/.venv/lib/python3.11/site-packages/git/cmd.py", line 741, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/gauthier/tmp/try-aider/.venv/lib/python3.11/site-packages/git/cmd.py", line 1315, in _call_process
    return self.execute(call, **exec_kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/gauthier/tmp/try-aider/.venv/lib/python3.11/site-packages/git/cmd.py", line 1109, in execute
    raise GitCommandError(redacted_command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git diff HEAD --color hello.py
  stderr: 'fatal: ambiguous argument 'HEAD': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]''

ASSISTANT: It seems like there is an issue with the `git diff` command in the `get_dirty_files_and_diffs` function. The error occurs because the 'HEAD' argument is ambiguous. To fix this issue, we can separate the paths from the revisions using '--'. Here's the change:

```python
aider/coder.py
<<<<<<< ORIGINAL
    these_diffs = repo.git.diff("HEAD", "--color", relative_fname)
=======
    these_diffs = repo.git.diff("HEAD", "--color", "--", relative_fname)
>>>>>>> UPDATED
```

This should resolve the `GitCommandError` you encountered.
2023-05-11 16:56:28 -07:00
Paul Gauthier
173a91a8c2 Fixed a bug in Coder class where the common root directory was not being set correctly. 2023-05-11 16:54:10 -07:00
Paul Gauthier
46cd8362b6 aider: Replaced "_" with the current working directory in find_common_root.
# Context:
USER: in find_common_root replace _ with the cwd
ASSISTANT: ```python
aider/coder.py
<<<<<<< ORIGINAL
        if not self.abs_fnames:
            self.root = _
=======
        if not self.abs_fnames:
            self.root = os.getcwd()
>>>>>>> UPDATED
```
2023-05-11 16:53:19 -07:00