From d1d043d92492f1fd4cbc116c124bbd40f7fbbaf6 Mon Sep 17 00:00:00 2001
From: Paul Gauthier <aider@paulg.org>
Date: Wed, 25 Sep 2024 14:09:44 -0700
Subject: [PATCH] fix: Simplify junior model assignment logic

---
 aider/models.py | 17 ++++++-----------
 1 file changed, 6 insertions(+), 11 deletions(-)

diff --git a/aider/models.py b/aider/models.py
index 0eb219335..88bb4bb7c 100644
--- a/aider/models.py
+++ b/aider/models.py
@@ -711,18 +711,13 @@ class Model(ModelSettings):
         if junior_edit_format:
             self.junior_edit_format = junior_edit_format
 
-        if not self.junior_model_name:
+        if not self.junior_model_name or self.junior_model_name == self.name:
             self.junior_model = self
-            return
-
-        if self.junior_model_name == self.name:
-            self.junior_model = self
-            return
-
-        self.junior_model = Model(
-            self.junior_model_name,
-            junior_model=False,
-        )
+        else:
+            self.junior_model = Model(
+                self.junior_model_name,
+                junior_model=False,
+            )
 
         if not self.junior_edit_format:
             self.junior_edit_format = self.junior_model.edit_format