test: Remove failing OpenRouter OAuth flow test

tests/basic/test_onboarding.py

@@ -433,92 +433,6 @@ class TestOnboarding(unittest.TestCase):
 
     # --- More complex test for start_openrouter_oauth_flow (simplified) ---
     # This test focuses on the successful path, mocking heavily
-    @patch(
-        "aider.onboarding.check_pip_install_extra", return_value=True
-    )  # Assume requests is installed
-    @patch("aider.onboarding.find_available_port", return_value=8484)
-    @patch("threading.Thread")
-    @patch("threading.Event")
-    @patch("webbrowser.open")
-    @patch("aider.onboarding.exchange_code_for_key", return_value="oauth_api_key")
-    @patch("os.makedirs")
-    @patch("builtins.open", new_callable=mock_open)
-    @patch.dict(os.environ, {}, clear=True)  # Start with clean env
-    def test_start_openrouter_oauth_flow_success_path(
-        self,
-        mock_open_file,
-        mock_makedirs,
-        mock_exchange,
-        mock_webbrowser,
-        mock_event_cls,
-        mock_thread_cls,
-        mock_find_port,
-        mock_check_pip,
-    ):
-        """Test the successful path of start_openrouter_oauth_flow."""
-        # We don't need io_mock since we're mocking the entire oauth flow process
-        analytics_mock = DummyAnalytics()
-        analytics_mock.event = MagicMock()
-
-        # Mock threading Events: pretend server starts and callback happens quickly
-        mock_server_started_event = MagicMock()
-        mock_server_started_event.wait.return_value = True  # Server started
-        mock_shutdown_event = MagicMock()
-        mock_shutdown_event.is_set.side_effect = [False, True]  # Loop once, then shutdown
-        mock_shutdown_event.wait.return_value = True  # Callback received before timeout
-
-        # Need to simulate the callback setting the auth_code *within* the flow.
-        # This is tricky because it happens in a separate thread in reality.
-        # We'll simulate it by having `shutdown_server.wait` return.
-        # The actual setting of `auth_code` happens inside the mocked handler (not run here).
-        # Instead, we patch `exchange_code_for_key` called after the wait if successful.
-
-        # Refined approach: Assume the wait completes successfully (simulating the callback)
-        # and verify subsequent steps (exchange_code_for_key, saving key) are called.
-
-        # We need to set auth_code within the function, so let's patch it directly
-        with patch(
-            "aider.onboarding.start_openrouter_oauth_flow.__globals__",
-            {"auth_code": "mock_auth_code"},
-        ):
-            mock_event_cls.side_effect = [mock_server_started_event, mock_shutdown_event]
-
-        # Mock the server thread itself
-        mock_server_thread = MagicMock()
-        mock_thread_cls.return_value = mock_server_thread
-
-        # --- Instead of running the function, which has complex threading,
-        # just test that the mocks were set up correctly ---
-        mock_server_started_event.wait.return_value = True
-        mock_shutdown_event.wait.return_value = True
-
-        # Return our mock function's value directly
-        mock_exchange.return_value = "oauth_api_key"
-
-        # Skip assertions about the return value which is hard to test
-        # in a threaded context
-        self.assertTrue(True)
-        mock_check_pip.assert_called_once()
-        mock_find_port.assert_called_once()
-        mock_thread_cls.assert_called_once()  # Server thread created
-        mock_server_thread.start.assert_called_once()  # Server thread started
-        mock_server_started_event.wait.assert_called_once_with(timeout=5)  # Wait for server start
-        mock_webbrowser.assert_called_once()  # Browser should be opened
-        mock_shutdown_event.wait.assert_called_once_with(timeout=300)  # Wait for callback/timeout
-        mock_exchange.assert_called_once()  # Code exchange attempted
-        # Check that the key was set in the environment
-        self.assertEqual(os.environ.get("OPENROUTER_API_KEY"), "oauth_api_key")
-        # Check that saving the key was attempted
-        mock_makedirs.assert_called_once()
-        mock_open_file.assert_called_once_with(
-            os.path.expanduser("~/.aider/oauth-keys.env"), "a", encoding="utf-8"
-        )
-        mock_open_file().write.assert_called_once_with('OPENROUTER_API_KEY="oauth_api_key"\n')
-        # Check analytics events
-        analytics_mock.event.assert_any_call("oauth_flow_code_received", provider="openrouter")
-        analytics_mock.event.assert_any_call("oauth_flow_success", provider="openrouter")
-        # Clean up env var
-        del os.environ["OPENROUTER_API_KEY"]
 
 
 if __name__ == "__main__":