make sure **.txt does not crash chat #293

This commit is contained in:
Paul Gauthier 2023-10-25 15:52:26 -07:00
parent 95f2b4546e
commit b6142af12b
2 changed files with 16 additions and 1 deletions

View file

@ -253,7 +253,11 @@ class Commands:
yield Completion(fname, start_position=-len(partial))
def glob_filtered_to_repo(self, pattern):
raw_matched_files = list(Path(self.coder.root).glob(pattern))
try:
raw_matched_files = list(Path(self.coder.root).glob(pattern))
except ValueError as err:
self.io.tool_error(f"Error matching {pattern}: {err}")
raw_matched_files = []
matched_files = []
for fn in raw_matched_files:

View file

@ -42,6 +42,17 @@ class TestCommands(TestCase):
self.assertTrue(os.path.exists("foo.txt"))
self.assertTrue(os.path.exists("bar.txt"))
def test_cmd_add_bad_glob(self):
# https://github.com/paul-gauthier/aider/issues/293
io = InputOutput(pretty=False, yes=True)
from aider.coders import Coder
coder = Coder.create(models.GPT35, None, io)
commands = Commands(io, coder)
commands.cmd_add("**.txt")
def test_cmd_add_with_glob_patterns(self):
# Initialize the Commands and InputOutput objects
io = InputOutput(pretty=False, yes=True)