From 49c78f2797b8f3d9b08a9ac49242014d941164c5 Mon Sep 17 00:00:00 2001
From: "Paul Gauthier (aider)" <aider@paulg.org>
Date: Sat, 30 Nov 2024 19:15:16 -0800
Subject: [PATCH] test: update voice tests to mock audio dependencies properly

---
 tests/basic/test_voice.py | 98 ++++++++++++++++++---------------------
 1 file changed, 46 insertions(+), 52 deletions(-)

diff --git a/tests/basic/test_voice.py b/tests/basic/test_voice.py
index c87e48944..e367f54ae 100644
--- a/tests/basic/test_voice.py
+++ b/tests/basic/test_voice.py
@@ -1,39 +1,37 @@
 import os
 import queue
-from unittest.mock import patch
+from unittest.mock import patch, MagicMock
 
 import numpy as np
 import pytest
 
 from aider.voice import SoundDeviceError, Voice
 
-
+# Mock the entire sounddevice module
 @pytest.fixture
 def mock_sounddevice():
-    with patch("sounddevice.query_devices") as mock_query:
-        mock_query.return_value = [
+    with patch('aider.voice.sounddevice') as mock_sd:
+        mock_sd.query_devices.return_value = [
             {"name": "test_device", "max_input_channels": 2},
             {"name": "another_device", "max_input_channels": 1},
         ]
-        yield mock_query
-
+        yield mock_sd
 
 @pytest.fixture
 def mock_soundfile():
-    with patch("soundfile.SoundFile") as mock_sf:
+    with patch('aider.voice.sf') as mock_sf:
         yield mock_sf
 
-
 def test_voice_init_default_device(mock_sounddevice):
     voice = Voice()
     assert voice.device_id is None
     assert voice.audio_format == "wav"
-
+    assert voice.sd == mock_sounddevice
 
 def test_voice_init_specific_device(mock_sounddevice):
     voice = Voice(device_name="test_device")
     assert voice.device_id == 0
-
+    assert voice.sd == mock_sounddevice
 
 def test_voice_init_invalid_device(mock_sounddevice):
     with pytest.raises(ValueError) as exc:
@@ -41,56 +39,52 @@ def test_voice_init_invalid_device(mock_sounddevice):
     assert "Device" in str(exc.value)
     assert "not found" in str(exc.value)
 
-
 def test_voice_init_invalid_format():
-    with pytest.raises(ValueError) as exc:
-        Voice(audio_format="invalid")
-    assert "Unsupported audio format" in str(exc.value)
-
+    with patch('aider.voice.sf', MagicMock()):  # Need to mock sf to avoid SoundDeviceError
+        with pytest.raises(ValueError) as exc:
+            Voice(audio_format="invalid")
+        assert "Unsupported audio format" in str(exc.value)
 
 def test_callback_processing():
-    voice = Voice()
-    voice.q = queue.Queue()
+    with patch('aider.voice.sf', MagicMock()):  # Need to mock sf to avoid SoundDeviceError
+        voice = Voice()
+        voice.q = queue.Queue()
 
-    # Test with silence (low amplitude)
-    test_data = np.zeros((1000, 1))
-    voice.callback(test_data, None, None, None)
-    assert voice.pct == 0.5  # When range is too small (<=0.001), pct is set to 0.5
+        # Test with silence (low amplitude)
+        test_data = np.zeros((1000, 1))
+        voice.callback(test_data, None, None, None)
+        assert voice.pct == 0.5  # When range is too small (<=0.001), pct is set to 0.5
 
-    # Test with loud signal (high amplitude)
-    test_data = np.ones((1000, 1))
-    voice.callback(test_data, None, None, None)
-    assert voice.pct > 0.9
-
-    # Verify data is queued
-    assert not voice.q.empty()
+        # Test with loud signal (high amplitude)
+        test_data = np.ones((1000, 1))
+        voice.callback(test_data, None, None, None)
+        assert voice.pct > 0.9
 
+        # Verify data is queued
+        assert not voice.q.empty()
 
 def test_get_prompt():
-    voice = Voice()
-    voice.start_time = voice.start_time = os.times().elapsed
-    voice.pct = 0.5  # 50% volume level
+    with patch('aider.voice.sf', MagicMock()):  # Need to mock sf to avoid SoundDeviceError
+        voice = Voice()
+        voice.start_time = os.times().elapsed
+        voice.pct = 0.5  # 50% volume level
 
-    prompt = voice.get_prompt()
-    assert "Recording" in prompt
-    assert "sec" in prompt
-    assert "█" in prompt  # Should contain some filled blocks
-    assert "░" in prompt  # Should contain some empty blocks
+        prompt = voice.get_prompt()
+        assert "Recording" in prompt
+        assert "sec" in prompt
+        assert "█" in prompt  # Should contain some filled blocks
+        assert "░" in prompt  # Should contain some empty blocks
 
+def test_record_and_transcribe_keyboard_interrupt():
+    with patch('aider.voice.sf', MagicMock()):
+        voice = Voice()
+        with patch.object(voice, 'raw_record_and_transcribe', side_effect=KeyboardInterrupt()):
+            result = voice.record_and_transcribe()
+            assert result is None
 
-@patch("sounddevice.InputStream")
-def test_record_and_transcribe_keyboard_interrupt(mock_stream):
-    voice = Voice()
-    mock_stream.side_effect = KeyboardInterrupt()
-
-    result = voice.record_and_transcribe()
-    assert result is None
-
-
-@patch("sounddevice.InputStream")
-def test_record_and_transcribe_device_error(mock_stream):
-    voice = Voice()
-    mock_stream.side_effect = SoundDeviceError("Test error")
-
-    result = voice.record_and_transcribe()
-    assert result is None
+def test_record_and_transcribe_device_error():
+    with patch('aider.voice.sf', MagicMock()):
+        voice = Voice()
+        with patch.object(voice, 'raw_record_and_transcribe', side_effect=SoundDeviceError("Test error")):
+            result = voice.record_and_transcribe()
+            assert result is None