refactor: use shlex.join for safer command string representation

This commit is contained in:
Paul Gauthier 2024-08-31 15:36:41 -07:00 committed by Paul Gauthier (aider)
parent 7c013dba6a
commit 0c5cd64b83
2 changed files with 4 additions and 2 deletions

View file

@ -1,5 +1,6 @@
import itertools
import os
import shlex
import subprocess
import sys
import tempfile
@ -314,7 +315,7 @@ def check_pip_install_extra(io, module, prompt, pip_install_cmd):
if prompt:
io.tool_error(prompt)
if not io.confirm_ask("Run pip install?", default="y", subject=" ".join(cmd)):
if not io.confirm_ask("Run pip install?", default="y", subject=shlex.join(cmd)):
return
success, output = run_install(cmd)

View file

@ -1,4 +1,5 @@
import os
import shlex
import sys
import time
from pathlib import Path
@ -96,7 +97,7 @@ Newer aider version v{latest_version} is available. To upgrade, run:
text = f"Newer aider version v{latest_version} is available. To upgrade, run:"
io.tool_error(text)
if io.confirm_ask("Run pip install?", subject=" ".join(cmd)):
if io.confirm_ask("Run pip install?", subject=shlex.join(cmd)):
success, output = utils.run_install(cmd)
if success:
io.tool_output("Re-run aider to use new version.")